Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding waffling60 Rev D ISO Hotswap #18372

Merged
merged 36 commits into from
Oct 1, 2022
Merged

Adding waffling60 Rev D ISO Hotswap #18372

merged 36 commits into from
Oct 1, 2022

Conversation

4pplet
Copy link
Contributor

@4pplet 4pplet commented Sep 15, 2022

Description

Adding the first PCB with the new revision of waffling60 Rev D. Project moves from ATmega32u2 to APM and STM32F072 due to the issue with stock/availability and age of the 32u2. Project will be split into Hotswap ISO, Hotswap ANSI and Solder. ANSI and Solder code will be added when prototyped and tested.

Thanks! <3

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

4pplet and others added 30 commits January 31, 2021 16:16
…readme

Added build command for rev c and bootloader instruction in the main readme
@4pplet
Copy link
Contributor Author

4pplet commented Sep 26, 2022

Thanks! License information added @drashna

@4pplet 4pplet requested a review from drashna September 27, 2022 12:17
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there appears to be only a single layout defined, could you change LAYOUT_all to just LAYOUT?

@drashna drashna requested a review from a team September 30, 2022 03:39
@4pplet 4pplet requested a review from drashna September 30, 2022 07:46
…nges requested in revision d

Fixed so older revisions compile properly as well as implementing changes requested in revision d
@4pplet 4pplet requested a review from drashna October 1, 2022 17:16
@fauxpark
Copy link
Member

fauxpark commented Oct 2, 2022

@4pplet Configurator keymaps also need updating.
image

@4pplet
Copy link
Contributor Author

4pplet commented Oct 4, 2022

Thanks, I'll look into this! :)

@4pplet 4pplet deleted the waffling60_ISO branch October 4, 2022 20:33
quinnyo pushed a commit to quinnyo/qmk_firmware that referenced this pull request Oct 21, 2022
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
tim-bennett83 pushed a commit to tim-bennett83/qmk_firmware that referenced this pull request Nov 9, 2022
* tag '0.18.9': (558 commits)
  `:flash`: print bootloader (qmk#18569)
  Add `tzarc/ghoul`. (qmk#18562)
  [Keyboard] Add Uni v4 keyboard (qmk#18280)
  [Keyboard] Add waffling60 Rev D ISO Hotswap (qmk#18372)
  Remove more RESET keycode references (qmk#18559)
  Djinn theme, allow force redraws (qmk#18558)
  onekey: fix quine keymap (qmk#18555)
  [Keyboard] Add Little Big Scroll 4  macropad  (qmk#18516)
  [Keymap] corne layout with mac/linux text editing shortcuts (qmk#18374)
  Fixup keebio/sinc (qmk#18551)
  Smith and Rune Iron 165R2 Refactor (qmk#18552)
  Forrcaho foldkb caps lock blink (qmk#17424)
  [Keyboard] handwired/tractyl_manuform: Arduino Micro (qmk#17199)
  [Keyboard] Add nightstar75 (qmk#18546)
  Rotary encoder setting is revised to solve a malfunction. (qmk#18227)
  Add Unicomp PC122 keyboard (qmk#18326)
  AceVice One's keymap for Kyria keyboard (qmk#18393)
  [Keyboard] Add mini42 (qmk#18491)
  [Keyboard] Add saevus cor (qmk#18368)
  [Keyboard] Fix tklfrlnrlmlao layout (qmk#18543)
  ...
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants