-
Notifications
You must be signed in to change notification settings - Fork 21.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v.2.4.0] Release Tracker #128436
Comments
Link to landed trunk PR (if applicable):
Link to release branch PR:
Criteria Category:
@atalman merged |
Link to landed trunk PR (if applicable): Link to release branch PR: Criteria Category:
@atalman merged |
Link to landed trunk PR (if applicable): Link to release branch PR: Criteria Category:
@atalman merged |
Link to landed trunk PR (if applicable): Link to release branch PR: Criteria Category:
@malfet merged |
Link to landed trunk PR (if applicable): Link to release branch PR: Criteria Category:
@malfet merged |
Link to landed trunk PR (if applicable):
Link to release branch PR: Criteria Category:
@malfet merged |
Link to landed trunk PR (if applicable): Link to release branch PR: Criteria Category:
@atalman merged |
Link to landed trunk PR (if applicable): Link to release branch PR: Criteria Category:
@atalman merged |
Link to landed trunk PR (if applicable): Link to release branch PR: Criteria Category:
@atalman merged |
Link to landed trunk PR (if applicable): Link to release branch PR: Criteria Category:
@atalman merged |
Link to landed trunk PR (if applicable):
Link to release branch PR: Criteria Category:
@atalman merged |
Link to landed trunk PR (if applicable): Link to release branch PR: Criteria Category:
@atalman merged |
Link to landed trunk PR (if applicable): Link to release branch PR: Criteria Category:
@atalman merged |
Link to landed trunk PR (if applicable): Link to release branch PR: Criteria Category:
@atalman merged |
Link to landed trunk PR (if applicable): Link to release branch PR: Criteria Category:
@atalman merged |
Link to landed trunk PR (if applicable): Link to release branch PR: Criteria Category:
Hi @xuhancn this looks like feature work to enable inductor on PyTorch Windows, however for release 2.4 we don't support this yet. @atalman merged. ToDo run manual validation on RC with test provided in the PR |
Link to landed trunk PR (if applicable): Link to release branch PR: Criteria Category:
@atalman merged |
Link to landed trunk PR (if applicable): Link to release branch PR: Criteria Category:
@atalman merged |
Link to landed trunk PR (if applicable): Link to release branch PR: Criteria Category:
@clee2000 merged |
This extends the capacity of the cherry-pick bot to automatically update the tracker issue with the information. For this to work, the tracker issue needs to be an open one with a `release tracker` label, i.e. #128436. The version from the release branch, i.e. `release/2.4`, will be match with the title of the tracker issue, i.e. `[v.2.4.0] Release Tracker` or `[v.2.4.1] Release Tracker` ### Testing `python cherry_pick.py --onto-branch release/2.4 --classification release --fixes "DEBUG DEBUG" --github-actor huydhn 128718` * On the PR #128718 (comment) * On the tracker issue #128436 (comment) Pull Request resolved: #128924 Approved by: https://github.com/atalman
Link to landed trunk PR (if applicable): Link to release branch PR: Criteria Category: @atalman merged |
Link to landed trunk PR (if applicable): Link to release branch PR: Criteria Category: @atalman merged |
Link to landed trunk PR (if applicable): Link to release branch PR: Criteria Category:
@atalman merged |
Link to landed trunk PR (if applicable): Link to release branch PR: Criteria Category: @atalman merged |
Link to landed trunk PR (if applicable):
Link to release branch PR: Criteria Category:
@oraluben please note: the PR must be landed in main in order to be considered for cherry-picking @malfet merged |
Link to landed trunk PR (if applicable): Link to release branch PR: Criteria Category: @atalman merged |
Wondering if we can get this landined in main so we can backport it. We've encoutered some hanging on certain hardware with certain firmware versions that only occur on this specific NCCL version (fixed in NCCL versions before and after): #124014 |
Link to landed trunk PR (if applicable): Link to release branch PR: Criteria Category: @atalman merged |
Link to landed trunk PR (if applicable): Link to release branch PR: Criteria Category:
@atalman merged |
Link to landed trunk PR (if applicable): Link to release branch PR: Criteria Category:
@atalman merged |
Link to landed trunk PR (if applicable): Link to release branch PR: Criteria Category: |
Please note, we are in: |
Link to landed trunk PR (if applicable): Link to release branch PR: Criteria Category:
@XuehaiPan This pr broke linux nightly binaries, please see here: https://hud2.pytorch.org/hud/pytorch/pytorch/nightly/1?per_page=50&name_filter=linux- . Conda builds will require forward fix. Here is the failure: https://github.com/pytorch/pytorch/actions/runs/10036618056/job/27749407507#step:17:663 . Looks like sympy 1.13 is not available on conda: https://anaconda.org/anaconda/sympy |
We cut a release branch for the 2.4.0 release.
Our plan from this point from this point is roughly:
This issue is for tracking cherry-picks to the release branch.
Cherry-Pick Criteria
Phase 1 (until 7/1/24):
Only low-risk changes may be cherry-picked from main:
Any other change requires special dispensation from the release managers (currently @atalman, @PaliC , @huydhn, @malfet). If this applies to your change please write "Special Dispensation" in the "Criteria Category:" template below and explain.
Phase 2 (after 7/1/24):
Note that changes here require us to rebuild a Release Candidate and restart extended testing (likely delaying the release). Therefore, the only accepted changes are Release-blocking critical fixes for: silent correctness, backwards compatibility, crashes, deadlocks, (large) memory leaks
Changes will likely require a discussion with the larger release team over VC or Slack.
Cherry-Pick Process
Ensure your PR has landed in master. This does not apply for release-branch specific changes (see Phase 1 criteria).
Create (but do not land) a PR against the release branch.
Make a request below with the following format:
NOTE: Our normal tools (ghstack / ghimport, etc.) do not work on the release branch.
Please note HUD Link with branch CI status and link to the HUD to be provided here.
HUD
Versions
2.4.0
The text was updated successfully, but these errors were encountered: