[inductor] fix linear add bias pattern (#128473) #128577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix pytorch#128287. Previous the assertion in `linear_add_bias` are pretty bad ``` assert packed_weight_node.name == "_reorder_linear_weight" assert transpose_weight_node.name == "permute_default" ``` because the `name` can be changed to `_reorder_linear_weight_id, permute_default_id` if we have more than 1 reorder/permute. Check `target` instead `name` can solve this issue. UT is also updated to have match more than 1 `linear_add_bias` pattern to cover this case. Co-authored-by: Jiong Gong <[email protected]> Pull Request resolved: pytorch#128473 Approved by: https://github.com/jgong5 (cherry picked from commit c53d65b)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128577
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 5f23f6d with merge base b66e3f0 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jgong5
approved these changes
Jun 13, 2024
atalman
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #128287. Previous the assertion in
linear_add_biasare pretty badbecause the
namecan be changed to_reorder_linear_weight_id, permute_default_idif we have more than 1 reorder/permute.Check
targetinsteadnamecan solve this issue.UT is also updated to have match more than 1
linear_add_biaspattern to cover this case.Co-authored-by: Jiong Gong [email protected]
Pull Request resolved: #128473
Approved by: https://github.com/jgong5
(cherry picked from commit c53d65b)
Fixes #ISSUE_NUMBER
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang