Clean up xpu ut to make CI happy (#128383) #128614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Motivation Before pytorch#127611 merged, the xpu-specific UT `test/test_xpu.py` was skipped temporarily. This PR aims to fix the UT bug introduced by pytorch#127741. Pull Request resolved: pytorch#128383 Approved by: https://github.com/EikanWang (cherry picked from commit 88974fe)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128614
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 5b62aa7 with merge base b66e3f0 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
atalman
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix UT and unblock the xpu CI: before #127611 merged, the xpu-specific UT test/test_xpu.py was skipped temporarily because the test cases were disabled by TD. This PR aims to fix the UT bug introduced by #127741 .
Pull Request resolved: #128383
Approved by: https://github.com/EikanWang
(cherry picked from commit 88974fe)