Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Make torch_geometric models compatible with export (#123403)"… #128511

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

chunyuan-w
Copy link
Collaborator

@chunyuan-w chunyuan-w commented Jun 12, 2024

… (#128377)

Cherry pick #128377 to release/2.4 branch.

Reverted on main to fix #127513: a regression issue that will impact the AOTI CPU performance on multiple CNN models in the dynamo benchmark.
The detailed impact are explained here.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang

Copy link

pytorch-bot bot commented Jun 12, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128511

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit 1f4cca6 with merge base b66e3f0 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@atalman atalman merged commit d71de3c into pytorch:release/2.4 Jun 19, 2024
163 of 166 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants