Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate torch._utils.is_compiling() and torch._dynamo.external_utils.is_compiling() #127690

Open
wants to merge 18 commits into
base: gh/XuehaiPan/38/base
Choose a base branch
from

Conversation

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jun 1, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/127690

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 56072ce with merge base fcef6cc (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor module: dynamo oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (ddp) release notes category labels Jun 1, 2024
XuehaiPan added a commit that referenced this pull request Jun 1, 2024
…tils.is_compiling()`

ghstack-source-id: 1a226d53e5845c81d103987f5e72a38afb1d0da3
Pull Request resolved: #127690
@XuehaiPan XuehaiPan added module: deprecation ciflow/trunk Trigger trunk jobs on your pull request topic: deprecation topic category labels Jun 1, 2024
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Jun 1, 2024
…tils.is_compiling()`

ghstack-source-id: 6c97e7e035a302890fa225d393364be0130c73c1
Pull Request resolved: #127690
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Jun 2, 2024
…tils.is_compiling()`

ghstack-source-id: 6728e5f7b858ee2b53d227f05f475f1dd3e6ac44
Pull Request resolved: #127690
@mikaylagawarecki mikaylagawarecki removed their request for review June 3, 2024 14:52
@XuehaiPan
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[ghstack-poisoned]
malfet pushed a commit that referenced this pull request Jun 19, 2024
…ternal_utils.is_compiling()` (#127690)" (#128542)

This reverts commit 348b181.
[ghstack-poisoned]
@albanD albanD requested review from zou3519 and removed request for albanD July 19, 2024 20:59
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Jul 20, 2024
…tils.is_compiling()`

ghstack-source-id: c403ea85a4ccf96bbec6421c070703ea47dbc68e
Pull Request resolved: #127690
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Aug 2, 2024
…tils.is_compiling()`

ghstack-source-id: e49d7a948f4341d300210a0a5c49cbe4e88fd83b
Pull Request resolved: #127690
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Aug 3, 2024
…tils.is_compiling()`

ghstack-source-id: edaef36e7caec643f54df9dbbdb7e36a7212efb9
Pull Request resolved: #127690
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Aug 3, 2024
…tils.is_compiling()`

ghstack-source-id: 0a1975600b7e465b808a160ec39d03717db15af0
Pull Request resolved: #127690
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Aug 3, 2024
…tils.is_compiling()`

ghstack-source-id: a90fa87c4063f6e1b580eb5d2e8dedbd3fa38bc7
Pull Request resolved: #127690
@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

aartbik pushed a commit that referenced this pull request Aug 3, 2024
@pytorch pytorch deleted a comment from pytorch-bot bot Aug 7, 2024
@kit1980
Copy link
Member

kit1980 commented Aug 7, 2024

@pytorchbot revert -m "breaking internal builds" -c ghfirst

Apparently torch._dynamo.is_compiling() is used internally at Meta
cc @PaliC

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Aug 7, 2024
…ternal_utils.is_compiling()` (#127690)"

This reverts commit 0e7e61f.

Reverted #127690 on behalf of https://github.com/kit1980 due to breaking internal builds ([comment](#127690 (comment)))
@pytorchmergebot
Copy link
Collaborator

@XuehaiPan your PR has been successfully reverted.

@kit1980
Copy link
Member

kit1980 commented Aug 7, 2024

Apparently torch._dynamo.is_compiling() is used internally at Meta

Or maybe the actual issue shows in JIT-compiled user code:

RuntimeError: 
undefined value torch:
return torch.compiler.is_compiling()
           ~~~~~ <--- HERE 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants