-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate torch._utils.is_compiling()
and torch._dynamo.external_utils.is_compiling()
#127690
base: gh/XuehaiPan/38/base
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/127690
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 56072ce with merge base fcef6cc (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…tils.is_compiling()` ghstack-source-id: 1a226d53e5845c81d103987f5e72a38afb1d0da3 Pull Request resolved: #127690
…tils.is_compiling()` ghstack-source-id: 6c97e7e035a302890fa225d393364be0130c73c1 Pull Request resolved: #127690
…tils.is_compiling()` ghstack-source-id: 6728e5f7b858ee2b53d227f05f475f1dd3e6ac44 Pull Request resolved: #127690
@pytorchbot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
…tils.is_compiling()` ghstack-source-id: c403ea85a4ccf96bbec6421c070703ea47dbc68e Pull Request resolved: #127690
…tils.is_compiling()` ghstack-source-id: e49d7a948f4341d300210a0a5c49cbe4e88fd83b Pull Request resolved: #127690
…tils.is_compiling()` ghstack-source-id: edaef36e7caec643f54df9dbbdb7e36a7212efb9 Pull Request resolved: #127690
…tils.is_compiling()` ghstack-source-id: 0a1975600b7e465b808a160ec39d03717db15af0 Pull Request resolved: #127690
…tils.is_compiling()` ghstack-source-id: a90fa87c4063f6e1b580eb5d2e8dedbd3fa38bc7 Pull Request resolved: #127690
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…tils.is_compiling()` (#127690) This PR is split from PR #126898. - #126898 ------ Pull Request resolved: #127690 Approved by: https://github.com/Skylion007, https://github.com/malfet
@pytorchbot revert -m "breaking internal builds" -c ghfirst Apparently |
@pytorchbot successfully started a revert job. Check the current status here. |
…ternal_utils.is_compiling()` (#127690)" This reverts commit 0e7e61f. Reverted #127690 on behalf of https://github.com/kit1980 due to breaking internal builds ([comment](#127690 (comment)))
@XuehaiPan your PR has been successfully reverted. |
Or maybe the actual issue shows in JIT-compiled user code:
|
This PR is split from PR #126898.
typing_extensions.deprecated
#126898Stack from ghstack (oldest at bottom):
torch._utils.is_compiling()
andtorch._dynamo.external_utils.is_compiling()
#127690cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @tianyu-l @peterbell10