Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-28972] Added 'Always On' option for new sidebar #6530

Merged
merged 3 commits into from
Sep 23, 2020

Conversation

devinbinnie
Copy link
Member

Summary

Added an Always On for sysadmins to force the new sidebar to be enabled for all users.

Ticket Link

https://mattermost.atlassian.net/browse/MM-28972

Related Pull Requests

@devinbinnie devinbinnie added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Sep 22, 2020
@devinbinnie devinbinnie added the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Sep 22, 2020
Copy link
Member

@marianunez marianunez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @devinbinnie!

The defaults for cloud are being set directly in the cloud-beta branch like in this PR mattermost/mattermost#15540

@devinbinnie devinbinnie removed the 2: Dev Review Requires review by a core commiter label Sep 22, 2020
@devinbinnie devinbinnie removed the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Sep 23, 2020
@stevemudie stevemudie added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Sep 23, 2020
Copy link
Contributor

@stevemudie stevemudie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevemudie stevemudie added QA Review Done and removed 3: QA Review Requires review by a QA tester labels Sep 23, 2020
@devinbinnie devinbinnie added the 4: Reviews Complete All reviewers have approved the pull request label Sep 23, 2020
@devinbinnie devinbinnie merged commit 6ff333f into mattermost:master Sep 23, 2020
@mattermod mattermod removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Sep 23, 2020
@mm-cloud-bot
Copy link

Test server destroyed

1 similar comment
@mm-cloud-bot
Copy link

Test server destroyed

@amyblais amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Sep 23, 2020
devinbinnie added a commit to devinbinnie/mattermost-webapp that referenced this pull request Sep 23, 2020
* [MM-28972] Added 'Always On' option for new sidebar

* Redux update
@devinbinnie devinbinnie removed their assignment Sep 23, 2020
@amyblais amyblais added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Sep 23, 2020
devinbinnie added a commit that referenced this pull request Sep 23, 2020
* [MM-28972] Added 'Always On' option for new sidebar

* Redux update
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Sep 24, 2020
Tak-Iwamoto pushed a commit to Tak-Iwamoto/mattermost-webapp that referenced this pull request Sep 28, 2020
…o MM-20457

* 'master' of github.com:Tak-Iwamoto/mattermost-webapp:
  [MM-28680] fix blank page on undefined message (mattermost#6450)
  MM-28733 : Admin Advisor v2 (mattermost#6461)
  MM 20547 user settings security ts (mattermost#6216)
  MM-20904 Add E2E tests for custom categories (mattermost#5981)
  Update NOTICE.txt (mattermost#6550)
  Check if emojiMap is undefined before invoking method for it (mattermost#6495)
  [MM-28151] Cypress/E2E: Automate backlogs - System Console > User Password (mattermost#6538)
  [MM-28295] e2e/messaging/reactions: add reactions spec (mattermost#6535)
  [MM-28706] revert ordering change for `in:` auto-suggest search results (mattermost#6493)
  Remove usage of t function with useIntl (mattermost#6552)
  MM-28992 Remove unused notPresent and mustBePresent props from MultiSelectSetting (mattermost#6544)
  MM-27530 Fix for Multiselect items not scrolling into view on arrow keys (mattermost#6286)
  Demoting failed test from prod (mattermost#6534)
  migrate show_more to typescript (mattermost#6501)
  [MM-28878] Revert style change to remove next steps arrow (mattermost#6527)
  [MM-28972] Added 'Always On' option for new sidebar (mattermost#6530)
  MM-28839 Fix for hover of cursor on indicators (mattermost#6524)
  [MM-28790] allow plugins to open in a different tab (mattermost#6476)
  MM-28290 Always update team member unread counts when added to a channel (mattermost#6500)
jfrerich pushed a commit that referenced this pull request Oct 23, 2020
* [MM-28972] Added 'Always On' option for new sidebar

* Redux update
calebroseland pushed a commit that referenced this pull request Oct 27, 2020
* [MM-28972] Added 'Always On' option for new sidebar

* Redux update
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation QA Review Done
Projects
None yet
7 participants