Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-28839 Fix for hover of cursor on indicators #6524

Merged
merged 5 commits into from
Sep 23, 2020
Merged

MM-28839 Fix for hover of cursor on indicators #6524

merged 5 commits into from
Sep 23, 2020

Conversation

sudheerDev
Copy link
Contributor

Summary

Replacing a tag with span tag to remove the hover

Ticket Link

https://mattermost.atlassian.net/browse/MM-28839

@sudheerDev sudheerDev added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Sep 22, 2020
@sudheerDev sudheerDev added this to the v5.28.0 milestone Sep 22, 2020
@sudheerDev sudheerDev added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Sep 22, 2020
Copy link
Member

@devinbinnie devinbinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, why was this an anchor in the first place? 😕

@devinbinnie devinbinnie removed the 2: Dev Review Requires review by a core commiter label Sep 22, 2020
@sudheerDev
Copy link
Contributor Author

Curious, why was this an anchor in the first place? 😕

Copied from an existing pattern, i was meant to remove it at the end but forgot about it

Copy link
Contributor

@jgilliam17 jgilliam17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sudheerDev
Tested, looks good to merge.

  • Verified cursor pointer on dot page indicators hover. Hand pointer has been removed.

@jgilliam17 jgilliam17 added QA Review Done and removed 3: QA Review Requires review by a QA tester labels Sep 23, 2020
@sudheerDev
Copy link
Contributor Author

Reverted the last two commits added after dev reviews made for hardcoding to ease QA testing

@sudheerDev sudheerDev added 4: Reviews Complete All reviewers have approved the pull request and removed Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Sep 23, 2020
@mm-cloud-bot
Copy link

Test server destroyed

@sudheerDev sudheerDev merged commit a98d4ae into master Sep 23, 2020
@mattermod
Copy link
Contributor

Cherry pick is scheduled.

@sudheerDev sudheerDev deleted the MM-28839 branch September 23, 2020 16:04
mattermost-build pushed a commit to mattermost-build/mattermost-webapp that referenced this pull request Sep 23, 2020
* MM-28839 Fix for hover of cursor on indicators

* Hardcode values for easy testing

* Update snapshots

* Revert "Hardcode values for easy testing"

This reverts commit 49e9c75.

* Revert "Update snapshots"

This reverts commit 1ec750f.

(cherry picked from commit a98d4ae)
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Sep 23, 2020
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Sep 23, 2020
mattermod pushed a commit that referenced this pull request Sep 23, 2020
Tak-Iwamoto pushed a commit to Tak-Iwamoto/mattermost-webapp that referenced this pull request Sep 28, 2020
…o MM-20457

* 'master' of github.com:Tak-Iwamoto/mattermost-webapp:
  [MM-28680] fix blank page on undefined message (mattermost#6450)
  MM-28733 : Admin Advisor v2 (mattermost#6461)
  MM 20547 user settings security ts (mattermost#6216)
  MM-20904 Add E2E tests for custom categories (mattermost#5981)
  Update NOTICE.txt (mattermost#6550)
  Check if emojiMap is undefined before invoking method for it (mattermost#6495)
  [MM-28151] Cypress/E2E: Automate backlogs - System Console > User Password (mattermost#6538)
  [MM-28295] e2e/messaging/reactions: add reactions spec (mattermost#6535)
  [MM-28706] revert ordering change for `in:` auto-suggest search results (mattermost#6493)
  Remove usage of t function with useIntl (mattermost#6552)
  MM-28992 Remove unused notPresent and mustBePresent props from MultiSelectSetting (mattermost#6544)
  MM-27530 Fix for Multiselect items not scrolling into view on arrow keys (mattermost#6286)
  Demoting failed test from prod (mattermost#6534)
  migrate show_more to typescript (mattermost#6501)
  [MM-28878] Revert style change to remove next steps arrow (mattermost#6527)
  [MM-28972] Added 'Always On' option for new sidebar (mattermost#6530)
  MM-28839 Fix for hover of cursor on indicators (mattermost#6524)
  [MM-28790] allow plugins to open in a different tab (mattermost#6476)
  MM-28290 Always update team member unread counts when added to a channel (mattermost#6500)
jfrerich pushed a commit that referenced this pull request Oct 23, 2020
* MM-28839 Fix for hover of cursor on indicators

* Hardcode values for easy testing

* Update snapshots

* Revert "Hardcode values for easy testing"

This reverts commit 49e9c75.

* Revert "Update snapshots"

This reverts commit 1ec750f.
calebroseland pushed a commit that referenced this pull request Oct 27, 2020
* MM-28839 Fix for hover of cursor on indicators

* Hardcode values for easy testing

* Update snapshots

* Revert "Hardcode values for easy testing"

This reverts commit 49e9c75.

* Revert "Update snapshots"

This reverts commit 1ec750f.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation QA Review Done
Projects
None yet
7 participants