Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub handle roland 6940 #7009

Merged
merged 2 commits into from
Jun 23, 2024
Merged

Add GitHub handle roland 6940 #7009

merged 2 commits into from
Jun 23, 2024

Conversation

jennisung
Copy link
Member

@jennisung jennisung commented Jun 15, 2024 •
edited
Loading

Fixes #6940

What changes did you make?

  • I added 'github handle' for Roland Abregorivas in heart.md

Why did you make the changes (we will use this info to test)?

  • The site wants to eventually add github handle for all members, so this task wants me to add one for Roland.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to the site.

image

No visual changes to the site.

image

@github-actions GitHub Actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b jennisung-add-github-handle-Roland-6940 gh-pages
git pull https://github.com/jennisung/website.git add-github-handle-Roland-6940

@t-will-gillis
Copy link
Member

Hi @jennisung Please add a comment to your previous PR that says that it is being replaced by this PR (include the #7009) and then close the previous PR- Thanks!

@daras-cu daras-cu self-requested a review June 17, 2024 18:58
@daras-cu
Copy link
Member

Review ETA: 1 pm 6/17/24
Availability: All day Monday, Tues-Fri after 6 pm Pacific Time

daras-cu
daras-cu requested changes Jun 17, 2024
View reviewed changes
Copy link
Member

@daras-cu daras-cu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jennisung, nice job with the changes! There are just a couple small things I think you need to change in the pull request, see below.

Correctly done:

  • Pull request was done with the correct branch
  • Understood and described the reason for the changes
  • File was changed correctly and website was not visually affected

Need to fix:

  • Link the pull request to the issue number (in the first line of the pull request, put the issue number where "replace_this_text_with_the_issue_number" is currently)
  • In the screenshot section, you can get rid of the before and after image sections and just note that there were no visual changes to the site

@mSharifHub
Copy link
Member

Hello @jennisung . So, the issue you having is same as the issue I Had. on the pull request form where it says Fixes, replace what you have with -> " Fixes #6940 ". The reason so the issue number serves as a direct link to the issue for other developers to look at. Also, certain task does not require screenshots. So, you can just say, No visual needed.

mSharifHub
mSharifHub previously requested changes Jun 17, 2024
View reviewed changes
Copy link
Member

@mSharifHub mSharifHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer to the comment I left in conversations for the Request Change

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jun 18, 2024
@jennisung jennisung mentioned this pull request Jun 18, 2024
Closed
@jennisung
Copy link
Member Author

Thank you for the suggestions! I close the previous pull request #7008 and made the comment after closing it. And updated the description for this pull request. All checks have passed.

@ExperimentsInHonesty ExperimentsInHonesty added role: back end and removed role: back end/devOps Tasks for back-end developers labels Jun 18, 2024
daras-cu
daras-cu approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@daras-cu daras-cu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your updates look good, well done!

@zkamenov zkamenov self-requested a review June 20, 2024 15:58
@zkamenov zkamenov self-assigned this Jun 20, 2024
@zkamenov
Copy link
Member

Review ETA: 1 PM 6/20/2024
Availability: 9AM - 6 PM Thursday

zkamenov
zkamenov approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@zkamenov zkamenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change in the file is relevant, accurate, and robust. Keep up the good work!

@t-will-gillis t-will-gillis dismissed mSharifHub’s stale review June 23, 2024 20:33

The dev is linking the previous issue with Fixes #6940

@t-will-gillis t-will-gillis merged commit bd234ab into hackforla:gh-pages Jun 23, 2024
11 of 13 checks passed
@jphamtv jphamtv mentioned this pull request Jun 27, 2024
Closed
terrencejihoonjung pushed a commit to terrencejihoonjung/website that referenced this pull request Jul 5, 2024
@jennisung @terrencejihoonjung
Add github-handle for Roland Abregorivas in heart.md hackforla#6940 (h…
4cc4eb9 
…ackforla#7009)
@ExperimentsInHonesty ExperimentsInHonesty added the role: back end/devOps Tasks for back-end developers label Jul 9, 2024
@daras-cu daras-cu mentioned this pull request Aug 11, 2024
Open
31 tasks
t-will-gillis added a commit that referenced this pull request Aug 18, 2024
@terrencejihoonjung @HackforLABot
@dcotelessa @santisecco @t-will-gillis @jennisung @williamzhang73 @melissam640 @alabador @DakuwoN @Kle012 @cchrizzle @duojet2ez @mrodz @DrAcula27 @vanessasinam @aadilahmed
Update Team Meeting Data on Events Page to show Meeting Frequency (#7088
5cb891d 
)

* updated-team-meeting-data-6920

* Update contributor and language data

* Update contributor and language data

* Fix Capitalization of "Slack" in CONTRIBUTING.MD - line 582 (#7038)

* Update contributor and language data

* Modified spell-check-audit.md file, changed label Feature: Administrative to feature: spelling (#7036)

* PBB migration "Issue Trigger"  (#7053)

* Update issue-trigger.yml

Changes in prep for Projects Beta migration

* Update issue-trigger.yml

space added to comment

* Update issue-trigger.yml

edits to comment at Team Members

* Update preliminary-update-comment.js

refactoring for PBB migration

* PBB migration "Pull Request Trigger" (#7054)

* Update pull-request-trigger.yml

edits for PBB migration

* Update pull-request-trigger.yml

remove test branch

* PBB migration "Schedule Friday" (#7055)

* Update schedule-fri-0700.yml

Changes for PBB migration

* Update add-label.js

* Update find-linked-issue.js

For PBB migration

* Update add-label.js

remove refs to personal repo

* Update add-label.js

addressing CodeQL alert

* Update add-label.js

address CodeQL alert

* PBB migration "Move Closed Issues" (#7056)

* Update move-closed-issues.yaml

for migration to PBB

* Update sort-closed-issues.js

* Add github-handle for Roland Abregorivas in heart.md #6940 (#7009)

* github-handle variable added for Gian Reyes Dionisio #6937 (#6984)

* Update contributor and language data

* updated role for Will Gillis on website project profile (#7063)

* Add github handle for Marie (#7059)

* added github handle element for Tien Yuan in heart.md (#7069)

* Update contributor and language data

* Fixes #7046 Added github handle to _projects/heart.md for Jason LaManque.

* Update Roslyn's role to Developer Co-Lead (#7070)

* img Tag Refactor in Contributing.md page  (#7068)

* Update contributor and language data

* Added github-handle to Adrian Inchauste's section (#7074)

* Update contributor and language data

* edited Samantha Hyler to be Co-lead AND added Emma Thrash (#7040)

* 6786 remove bop from untaggedrepoids in get project datajs (#7062)

* remove references to BoP's id from the `untaggedRepoIds` list

* Update contributor and language data

* Revert `github.repository` post GHA test

* Resolve merge conflicts

* Resolve merge conflicts (p2)

---------

Co-authored-by: GitHub Actions Bot <[email protected]>

* Update CONTRIBUTING.md Section 2.7.d with correct stream branch (#7082)

* Update meeting data

* Update contributor and language data

* Update Inactive Members JSON

* Revert "updated-team-meeting-data-6920 (#7043)" (#7086)

This reverts commit dc11c65.

* Update contributor and language data

* Update contributor and language data

* updated team meeting data on events page to show meeting frequency

* Add 'Leadership Option' to Issue Template for CoP Information Update (#7077)

* add leadership type option with dropdown fields

* remove whitespace between labels and body

* remove whitespace in title

* remove whitespace in front of the yes/no options

* change default type

* Update contributor and language data

* Updated spell checker to ignore memebers names (#7073)

* Update contributor and language data

* Update contributor and language data

* truncate contributors name in filter tag with ellipis (#7052)

* Update contributor and language data

---------

Co-authored-by: GitHub Actions Bot <[email protected]>
Co-authored-by: David Cotelessa <[email protected]>
Co-authored-by: Santiago Secco <[email protected]>
Co-authored-by: Will Gillis <[email protected]>
Co-authored-by: Jennifer Sung <[email protected]>
Co-authored-by: williamzhang <[email protected]>
Co-authored-by: Melissa McGrath <[email protected]>
Co-authored-by: Austin Labador <[email protected]>
Co-authored-by: Matthew McCane <[email protected]>
Co-authored-by: Kim <[email protected]>
Co-authored-by: Christopher Chang <[email protected]>
Co-authored-by: duojet2ez <[email protected]>
Co-authored-by: Mateo Rodriguez <[email protected]>
Co-authored-by: Danielle Andrews <[email protected]>
Co-authored-by: vanessasinam <[email protected]>
Co-authored-by: Aadil Ahmed <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkamenov zkamenov zkamenov approved these changes

@daras-cu daras-cu daras-cu approved these changes

@mSharifHub mSharifHub Awaiting requested review from mSharifHub

Assignees

@zkamenov zkamenov

Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add github-handle for Roland Abregorivas in heart.md
6 participants
@jennisung @t-will-gillis @daras-cu @mSharifHub @zkamenov @ExperimentsInHonesty