Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Capitalization of "Slack" in CONTRIBUTING.MD #7038

Merged

Conversation

dcotelessa
Copy link
Member

@dcotelessa dcotelessa commented Jun 19, 2024

Fixes #6932

What changes did you make?

  • capitalize slack to Slack on line 582 of CONTRIBUTING.md
  • Do not change any other lines in the file.
  • Reviewed changes on URL below

Why did you make the changes (we will use this info to test)?

Screenshots of Proposed Changes Of The Website

  • No visual changes on the website

@HackforLABot HackforLABot added this to PR Needs review (Automated Column, do not place items here manually) in Project Board Jun 19, 2024
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/dcotelessa/website/blob/fix-capitalization-slack-6932/CONTRIBUTING.md  

@github-actions github-actions bot added role: front end Tasks for front end developers Feature: Onboarding/Contributing.md Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less labels Jun 19, 2024
@buneeIsSlo buneeIsSlo self-requested a review June 20, 2024 07:24
@buneeIsSlo
Copy link
Member

Review ETA: e.o.d
Availability: 5 pm - 10 pm Weekdays

Copy link
Member

@buneeIsSlo buneeIsSlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dcotelessa Great job!

  • The branches from and to are setup correctly
  • The original issue is linked correctly
  • There is a clear and succinct description of what was done
  • Changes made do not affect the website
  • Extra points for adding a note for reviewers

Great work again, and thanks for working on this issue!

Project Board automation moved this from PR Needs review (Automated Column, do not place items here manually) to test-approved-by-reviewer (Automated Column, do not place items here manually) Jun 20, 2024
@jchue jchue self-requested a review June 22, 2024 17:54
@jchue
Copy link
Member

jchue commented Jun 22, 2024

  • ETA: EOD
  • Availability: After 5 PM PDT weekdays

Copy link
Member

@jchue jchue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @dcotelessa, well done.

  • Branching is correct
  • Correctly linked issue
  • Markdown file updated correctly
  • Slack URL unchanged

@drakenguyen4000 drakenguyen4000 merged commit b9b1caa into hackforla:gh-pages Jun 23, 2024
12 checks passed
@HackforLABot HackforLABot removed this from test-approved-by-reviewer (Automated Column, do not place items here manually) in Project Board Jun 23, 2024
terrencejihoonjung pushed a commit to terrencejihoonjung/website that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Onboarding/Contributing.md role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Capitalization of "Slack" in CONTRIBUTING.MD
4 participants