-
-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Team Meeting Data on the Events page to Show Meeting Frequency #7043
Update Team Meeting Data on the Events page to Show Meeting Frequency #7043
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: 3 PM 6/26/24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @terrencejihoonjung I have a question. My knowledge in front-end is limited.
When running the website with the changes I see in the events page the addition of:
"*This meeting is not weekly, check project link for more details."
However, I see no event with the * in the end like your function does when "isWeekly":false
Could you help me understand that?
Hi @jennisung - please provide your Review ETA and Availability when you have a moment. Thanks! |
Hi @santisecco, Sure! The first thing I would do is make sure all my changes exist on your fork. This includes the modified JSON in If there's anything about changes made specifically that you want to ask about, I'm happy to explain further! |
Review ETA: By 10 PM 6/29/24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Everything looks good on my end in Docker, and I see the added text at the end of the Online Project Team Meetings page. I also noticed that you updated the team meeting data to incorporate the asterisk (*) notation for non-weekly meetings per issue #6920.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@terrencejihoonjung Thanks for the explanation! Yeah my question was more related to the JSON file.
Your explanation is clear, I had kind of understood what you were trying to do with insertEventSchedule
but when I visualized in docker I couldn't see the "*" added. However, today I can see it displayed.
Displayed events seem to change on a week by week basis so last week, maybe, I saw all events that were "weekly" only, so no * added, or my data was not updated. If you look at your screenshot Thursday is different, with one more *.
Still I can see that the function works now also in my end.
Great job, changes to the code are clear and accurate and you provided a clear and concise explanation of the reasons for the changes. You created the pull request with the correct branch.
Thanks for working on this and explaining!
This reverts commit dc11c65.
NOTE: opened #7086 to revert this PR |
) This reverts commit dc11c65.
Fixes #6920
What changes did you make?
vrms_data.json
to include"isWeekly": {boolean}
key-value pair based on meeting description's contentdisplay_object
function to include this property for each event objectWhy did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
>Visuals after changes are applied