Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change label in spell check issue template #7036

Merged

Conversation

santisecco
Copy link
Member

Fixes #6857

What changes did you make?

  • I changed the label 'Feature: Administrative' to 'feature: spelling' in the file spell-check-audit.md that works as template for the issues "Run VS Code Spell Checker on [INSERT FILE HERE]"

Why did you make the changes (we will use this info to test)?

  • So the issues generated from the above mentioned template are properly labeled.

For Reviewers

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to the website.

@HackforLABot HackforLABot added this to PR Needs review (Automated Column, do not place items here manually) in Project Board Jun 19, 2024
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b santisecco-change-label-spellcheck-6857 gh-pages
git pull https://github.com/santisecco/website.git change-label-spellcheck-6857

@github-actions github-actions bot added Feature: Administrative Administrative chores etc. role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Medium size: 1pt Can be done in 4-6 hours feature: spelling role: back end labels Jun 19, 2024
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @santisecco - Everything looks good- branches are correct, there is a link back to the original issue, there are descriptions of what was changed and why, there is a link demonstrating the template form has the new labelling, there are no changes to the website, and the code edits are clean.

Great job and thanks for working on this!

Project Board automation moved this from PR Needs review (Automated Column, do not place items here manually) to test-approved-by-reviewer (Automated Column, do not place items here manually) Jun 21, 2024
@t-will-gillis t-will-gillis merged commit f557f73 into hackforla:gh-pages Jun 23, 2024
10 checks passed
@HackforLABot HackforLABot removed this from test-approved-by-reviewer (Automated Column, do not place items here manually) in Project Board Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Administrative Administrative chores etc. feature: spelling role: back end/devOps Tasks for back-end developers role: back end role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the Feature: Administrative label to feature: spelling in spell check issue template
2 participants