-
-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add github-handle variable for Gian Reyes Dionisio #6984
add github-handle variable for Gian Reyes Dionisio #6984
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Hi williamzhang, Thanks for the PR. We need a few updates:
Look forward to the update, thanks! |
Thanks @dcotelessa,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates.
The description looks good and the passing all tests.
Great job!
Review ETA: 6/11/2024 EOD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
- Correctly merging from collaborator's branch into hackforla:gh-pages
- Issue is correctly fixed (github-handle: added)
Approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Issue number was properly linked
- Branch naming is good (just a side note for future reference, no need to make change on this one: branch naming is more clear if you could include the name of the person, e.g.
add-github-handle-for-bryon-heart-6730
)
Changes required:
-
Remove
6937
from the title (notice how it becomes unclear since it stacks with your PR number) -
Use syntax highlight when referencing changes made so that it's clear to read, e.g. below:
![Screenshot 2024-06-11 at 6 57 44 PM](https://private-user-images.githubusercontent.com/169487538/338798231-1853e28d-c229-4f90-a475-cdc3094e57ed.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE4ODI4ODUsIm5iZiI6MTcyMTg4MjU4NSwicGF0aCI6Ii8xNjk0ODc1MzgvMzM4Nzk4MjMxLTE4NTNlMjhkLWMyMjktNGY5MC1hNDc1LWNkYzMwOTRlNTdlZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzI1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcyNVQwNDQzMDVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mNTk1ZmZiMmQ5YTIyOTk2YmI0OTdlOTkyZjlmNTU4Zjc2MGUwMTRiOTJmOTBiNzZlMDUzNzI4ZjRjMDM3MWNkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.aYmbeAAtMNKRFbk6bw-ZVcfuR-il2znA8aCmGK_81Z8)
-
Revise the
Why did you make the changes
answer: In general, it's a good practice to write details in your own words based on the request from the issue, e.g. Added Github-handle for Bryon Heart #6917 -
Please include this at the end if no visual change is made to the website:
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
- No visual change on the website.
After making all these changes, don't forget to click on something like this on the top right of your page (see below) to request a review of your changes:
![Screenshot 2024-06-06 at 8 45 27 PM](https://private-user-images.githubusercontent.com/169487538/337517051-5d31261b-a947-4a5a-8c57-4dea4c9e5396.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE4ODI4ODUsIm5iZiI6MTcyMTg4MjU4NSwicGF0aCI6Ii8xNjk0ODc1MzgvMzM3NTE3MDUxLTVkMzEyNjFiLWE5NDctNGE1YS04YzU3LTRkZWE0YzllNTM5Ni5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzI1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcyNVQwNDQzMDVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iYzQ5MGZlOTk5Zjc3ZTBjYjkxYjZiMTEzMmQ3NDNkOGQzMjU1MGU2YzMzYjZmMDAxOTZhN2JhNmIzYzYzZTFhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.wrYZmCzUyUbf5GHRsYht77zzd3Pvz_xw0N9RhrXvQSk)
@andyphancode Just noticed that your view mentioned |
ETA: 06/13/24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @williamzhang73 Well done! Good job!
- The branching was done correctly
- No need to mention issue number in the PR title. Refer to this guide https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md
- Issue number was listed
- Not all pull requests will have significant changes to our website. Please just add the following explanation for no images like:
### Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes to the website.
Please refer to the Contributing Guide: https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md - Changes were made correctly in the code
- Please provide a more detailed explanation of why the changes are being made
Thank you! Just make these changes, and I'll be happy to approve it.
Hi @williamzhang73 - Please update the "What changes did you make?" summary according to @ino-iosdev's feedback:
![]() Tip: Remove the underscores (_), and use backticks (`) instead Once updated, ping @ino-iosdev to review and approve the changes. This PR is ready to be merged and is only waiting for this final update. Thanks! |
The requested changes have been made
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes!
Fixes #6937
What changes did you make?
-add
github-handle:
for Gian Reyes DionisioWhy did you make the changes (we will use this info to test)?
-add Github handle variable for Gian Reyes Dinnisio to reduce redundancy in the project file.
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
-No visual change on the website.