Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add github-handle variable for Gian Reyes Dionisio #6984

Merged

Conversation

williamzhang73
Copy link
Member

@williamzhang73 williamzhang73 commented Jun 10, 2024

Fixes #6937

What changes did you make?

-add github-handle: for Gian Reyes Dionisio

Why did you make the changes (we will use this info to test)?

-add Github handle variable for Gian Reyes Dinnisio to reduce redundancy in the project file.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

-No visual change on the website.

@HackforLABot HackforLABot added this to PR Needs review (Automated Column, do not place items here manually) in Project Board Jun 10, 2024
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b williamzhang73-add-github-handle-6937 gh-pages
git pull https://github.com/williamzhang73/website.git add-github-handle-6937

@dcotelessa
Copy link
Member

Hi williamzhang,

Thanks for the PR. We need a few updates:

  • In the PR description, we need to replace "Fixes #replace_this_text_with_the_issue_number" with the number of the ticket, linking the task to the ticket. This is described here
  • Also, we can remove the "Screenshots" portion of the PR description as there are no visual changes.
  • The github-handle is applied and left blank , as the task is described.

Look forward to the update, thanks!

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jun 11, 2024
@williamzhang73
Copy link
Member Author

williamzhang73 commented Jun 11, 2024

Thanks @dcotelessa,

  1. The issue number was updated.
  2. The "screenshots" part of the PR description was removed.
    please review it again.

Copy link
Member

@dcotelessa dcotelessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates.
The description looks good and the passing all tests.
Great job!

Project Board automation moved this from PR Needs review (Automated Column, do not place items here manually) to test-approved-by-reviewer (Automated Column, do not place items here manually) Jun 11, 2024
@andyphancode andyphancode self-requested a review June 12, 2024 00:50
@andyphancode
Copy link
Member

Review ETA: 6/11/2024 EOD
Availability: Throughout week

Copy link
Member

@andyphancode andyphancode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

  • Correctly merging from collaborator's branch into hackforla:gh-pages
  • Issue is correctly fixed (github-handle: added)

Approved.

@ino-iosdev ino-iosdev self-requested a review June 12, 2024 01:18
Project Board automation moved this from test-approved-by-reviewer (Automated Column, do not place items here manually) to test-pending-approval (Automated Column, do not place items here manually) Jun 12, 2024
Copy link
Member

@ino-iosdev ino-iosdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@williamzhang73

  • Issue number was properly linked
  • Branch naming is good (just a side note for future reference, no need to make change on this one: branch naming is more clear if you could include the name of the person, e.g. add-github-handle-for-bryon-heart-6730)

Changes required:

  1. Remove 6937 from the title (notice how it becomes unclear since it stacks with your PR number)

  2. Use syntax highlight when referencing changes made so that it's clear to read, e.g. below:

Screenshot 2024-06-11 at 6 57 44 PM
  1. Revise the Why did you make the changes answer: In general, it's a good practice to write details in your own words based on the request from the issue, e.g. Added Github-handle for Bryon Heart #6917

  2. Please include this at the end if no visual change is made to the website:

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

-  No visual change on the website. 

After making all these changes, don't forget to click on something like this on the top right of your page (see below) to request a review of your changes:

Screenshot 2024-06-06 at 8 45 27 PM

@ino-iosdev
Copy link
Member

Looks good!

  • Correctly merging from collaborator's branch into hackforla:gh-pages

  • Issue is correctly fixed (github-handle: added)

Approved.

@andyphancode Just noticed that your view mentioned merging, since this is a pushing only, and the merge team will be handling merging once it's approved overall, I would kindly suggest to say correctly pushing instead to avoid confusing. Hope this make sense, cheers!

@del9ra del9ra self-requested a review June 14, 2024 00:31
@del9ra
Copy link
Member

del9ra commented Jun 14, 2024

ETA: 06/13/24
Availability: 1-5 PM monday-friday

Copy link
Member

@del9ra del9ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @williamzhang73 Well done! Good job!

  • The branching was done correctly
  • No need to mention issue number in the PR title. Refer to this guide https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md
  • Issue number was listed
  • Not all pull requests will have significant changes to our website. Please just add the following explanation for no images like:
    ### Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
    No visual changes to the website.
    Please refer to the Contributing Guide: https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md
  • Changes were made correctly in the code
  • Please provide a more detailed explanation of why the changes are being made
    Thank you! Just make these changes, and I'll be happy to approve it.

@williamzhang73 williamzhang73 changed the title github-handle variable added for Gian Reyes Dionisio #6937 add github-handle variable for Gian Reyes Dionisio Jun 16, 2024
@ExperimentsInHonesty ExperimentsInHonesty added role: back end and removed role: back end/devOps Tasks for back-end developers labels Jun 18, 2024
@github-actions github-actions bot added the role: back end/devOps Tasks for back-end developers label Jun 18, 2024
@williamzhang73 williamzhang73 removed the role: back end/devOps Tasks for back-end developers label Jun 18, 2024
@github-actions github-actions bot added the role: back end/devOps Tasks for back-end developers label Jun 18, 2024
@jphamtv
Copy link
Member

jphamtv commented Jun 20, 2024

Hi @williamzhang73 - Please update the "What changes did you make?" summary according to @ino-iosdev's feedback:

  1. Use syntax highlight when referencing changes made so that it's clear to read, e.g. below:
Screenshot 2024-06-11 at 6 57 44 PM

Tip: Remove the underscores (_), and use backticks (`) instead

Once updated, ping @ino-iosdev to review and approve the changes. This PR is ready to be merged and is only waiting for this final update. Thanks!

@t-will-gillis t-will-gillis dismissed ino-iosdev’s stale review June 23, 2024 20:39

The requested changes have been made

@t-will-gillis t-will-gillis merged commit c41c80c into hackforla:gh-pages Jun 23, 2024
15 of 16 checks passed
Copy link
Member

@ino-iosdev ino-iosdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes!

terrencejihoonjung pushed a commit to terrencejihoonjung/website that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Archived in project
Project Board
  
test-pending-approval (Automated Colu...
Development

Successfully merging this pull request may close these issues.

Add github-handle for Gian Reyes Dionisio in heart.md
8 participants