Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tests for DomainCountLimiter #757

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

priettt
Copy link
Contributor

@priettt priettt commented Apr 17, 2024

Goal

Moved the tests that were present in EmbraceNetworkLoggingService to DomainCountLimiter

@priettt priettt marked this pull request as ready for review April 17, 2024 20:47
@priettt priettt requested a review from a team as a code owner April 17, 2024 20:47
This was referenced Apr 17, 2024
Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

bidetofevil commented Apr 18, 2024

Merge activity

  • Apr 18, 7:50 PM EDT: @bidetofevil started a stack merge that includes this pull request via Graphite.
  • Apr 18, 8:04 PM EDT: Graphite rebased this pull request as part of a merge.
  • Apr 18, 8:07 PM EDT: @bidetofevil merged this pull request with Graphite.

@bidetofevil bidetofevil force-pushed the network-logging-service-tests branch from 49587b0 to 503c01b Compare April 19, 2024 00:01
Base automatically changed from network-logging-service-tests to master April 19, 2024 00:03
@bidetofevil bidetofevil merged commit 4b8b515 into master Apr 19, 2024
1 of 2 checks passed
@bidetofevil bidetofevil deleted the domain-count-limiter-tests branch April 19, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants