Added a SchemaType for mapping an EmbraceNetworkRequest to OTel compliant attributes #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsitoPuglisi
approved these changes
Apr 17, 2024
This was referenced Apr 17, 2024
bidetofevil
reviewed
Apr 17, 2024
| "error.type" to networkRequest.errorType, | ||
| "error.message" to networkRequest.errorMessage, | ||
| "emb.w3c_traceparent" to networkRequest.w3cTraceparent, | ||
| "emb.trace_id" to getValidTraceId(networkRequest.traceId), |
There was a problem hiding this comment.
we should rename this as it is confusing in terms of what traceId means in OTel.
bidetofevil
reviewed
Apr 17, 2024
| @@ -195,6 +197,20 @@ internal sealed class SchemaType( | |||
| ).toNonNullMap() | |||
| } | |||
|
|
|||
| internal class NetworkRequest(networkRequest: EmbraceNetworkRequest) : SchemaType(EmbType.Performance.Network) { | |||
| override val attrs = mapOf( | |||
| "url.full" to networkRequest.url, | |||
There was a problem hiding this comment.
we'll move to the semantic conventions if they can fix it in time - otherwise, we can move these into OpenTelemetryAttributeKeys later
bidetofevil
reviewed
Apr 17, 2024
bidetofevil
approved these changes
Apr 17, 2024
This was referenced Apr 17, 2024
Merged
6e4df14
to
7db70d7
Compare
9be830b
to
97196f8
Compare
Merge activity
|
7db70d7
to
1b90b3f
Compare
97196f8
to
c0bc028
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This will be used in EmbraceNetworkLoggingService to map from an EmbraceNetworkRequest to the correct span attributes.
We verified with backend that removing null attributes would cause no issues, so we are using toNonNullMap()