Moved the logic for counting domain limits to a new class #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 17, 2024
This was referenced Apr 17, 2024
Merged
bidetofevil
reviewed
Apr 18, 2024
|
|
||
| override fun logNetworkRequest(networkRequest: EmbraceNetworkRequest) { | ||
| logNetworkCaptureData(networkRequest) | ||
| processNetworkRequest(networkRequest) | ||
| recordNetworkRequest(networkRequest) |
There was a problem hiding this comment.
We probably want to log the network request first before we send the data capture since that seems more important?
bidetofevil
reviewed
Apr 18, 2024
| */ | ||
| private fun processNetworkRequest(networkRequest: EmbraceNetworkRequest) { | ||
| private fun recordNetworkRequest(networkRequest: EmbraceNetworkRequest) { | ||
| // TODO: Shouldn't we ignore domains that can't be parsed for networkCapturedData too? |
There was a problem hiding this comment.
Log a KTLO task and move on - not sure how these are related, so lets detangle this later
bidetofevil
reviewed
Apr 18, 2024
| ) : MemoryCleanerListener { | ||
|
|
||
| private val domainSetting = ConcurrentHashMap<String, DomainSettings>() | ||
| private val callsPerDomainSuffix = hashMapOf<String, NetworkSessionV2.DomainCount>() |
There was a problem hiding this comment.
This could be accessed concurrently so we need to use a threadsafe map
bidetofevil
reviewed
Apr 18, 2024
| private var domainSuffixCallLimits = configService.networkBehavior.getNetworkCallLimitsPerDomainSuffix() | ||
|
|
||
| fun canLogNetworkRequest(domain: String): Boolean { | ||
| // TODO: Should we synchronize on another object now that we don't use callsStorageLastUpdate? |
There was a problem hiding this comment.
If we don't synchronize, we might get a few network requests above the absolute max. That might be fine...?
bidetofevil
reviewed
Apr 18, 2024
This was referenced Apr 18, 2024
priettt
force-pushed
the
record-network-span
branch
from
5bdad96
to
21e7adf
Compare
priettt
force-pushed
the
domain-count-limiter
branch
from
e852564
to
c4e3c1e
Compare
bidetofevil
approved these changes
Apr 18, 2024
Merge activity
|
bidetofevil
force-pushed
the
record-network-span
branch
from
21e7adf
to
31d4443
Compare
bidetofevil
force-pushed
the
domain-count-limiter
branch
from
c4e3c1e
to
30a58da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Extracted the logic for counting domain limits to another class. This will allow us to test it more thoroughly in the future, as we detected some inconsistencies. It also keeps the NetworkLogging service cleaner.
Questions: