Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial prep for sending network requests as spans #745

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

priettt
Copy link
Contributor

@priettt priettt commented Apr 17, 2024

Goal

This is the initial PR for sending network requests as spans.

  • Removed recordAndDeduplicateNetworkRequest.

This was used in HttpURLConnectionDelegate to avoid logging network requests with the same call ID. It is still required, but we will address it differently in the following PRs. For now, we will use the same method as the rest of the requests.

  • logNetworkError and logNetworkCall did essentially the same. We will move that logic to the logging service so we don't bloat EmbraceImpl

  • getNetworkCallsSnapshot won't be used anymore, as we will record spans directly when they get to the logging service. We won't need to expose them when the session ends.

  • Stop looking for network logs in PerformanceInfo. Removed "nr" from session-end.json. We won't be sending network requests there anymore.

  • Updated tests to use the new APIs

@priettt priettt marked this pull request as ready for review April 17, 2024 14:09
@priettt priettt requested a review from a team as a code owner April 17, 2024 14:09
Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥 This is so awesome 😭 😭 😭

Copy link
Collaborator

bidetofevil commented Apr 18, 2024

Merge activity

@bidetofevil bidetofevil merged commit 2c3bd85 into master Apr 18, 2024
1 of 4 checks passed
@bidetofevil bidetofevil deleted the network-request-spans branch April 18, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants