Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tests for EmbraceNetworkLoggingService #755

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

priettt
Copy link
Contributor

@priettt priettt commented Apr 17, 2024

Goal

Added unit tests for EmbraceNetworkLoggingService

Many of the existing tests will be moved to the DomainCountLimiter tests in a following PR

@priettt priettt marked this pull request as ready for review April 17, 2024 18:58
@priettt priettt requested a review from a team as a code owner April 17, 2024 18:58
Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the other tests that get added back along with these will cover all the previous test cases

Copy link
Collaborator

bidetofevil commented Apr 18, 2024

Merge activity

  • Apr 18, 7:50 PM EDT: @bidetofevil started a stack merge that includes this pull request via Graphite.
  • Apr 18, 8:02 PM EDT: Graphite rebased this pull request as part of a merge.
  • Apr 18, 8:03 PM EDT: @bidetofevil merged this pull request with Graphite.

Base automatically changed from domain-count-limiter to master April 19, 2024 00:01
@bidetofevil bidetofevil force-pushed the network-logging-service-tests branch from 49587b0 to 503c01b Compare April 19, 2024 00:01
@bidetofevil bidetofevil merged commit b153a68 into master Apr 19, 2024
1 of 2 checks passed
@bidetofevil bidetofevil deleted the network-logging-service-tests branch April 19, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants