Convert private span attribute to EmbraceAttributes

[bidetofevil]

Goal

Convert emb.private to an EmbraceAttribute

Testing

Existing tests cover this

[bidetofevil]

• Convert private span attribute to EmbraceAttributes #534 👈
• Add in extension functions useful when working with EmbraceAttributes #533
• Make EmbType a TelemetryType and make TelemetryType an EmbraceAttribute #531
• Refactor how Embrace attributes are defined #526
• Delete EmbraceAttributes.Type and consolidate on EmbType #525
• Add session and key name to EmbType and TelemetryType respectively #524
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on Graphite

[fractalwrench]

LGTM

[codecov]

Codecov Report

Attention: Patch coverage is 96.15385% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 79.51%. Comparing base (5e18d90) to head (3da10fb).
Report is 21 commits behind head on master.

❗ Current head 3da10fb differs from pull request most recent head 7a636ef. Consider uploading reports for the commit 7a636ef to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #534      +/-   ##
==========================================
+ Coverage   79.45%   79.51%   +0.05%     
==========================================
  Files         403      408       +5     
  Lines       10861    10871      +10     
  Branches     1602     1602              
==========================================
+ Hits         8630     8644      +14     
+ Misses       1585     1581       -4     
  Partials      646      646              

Files	Coverage Δ
...ndroid/embracesdk/arch/destination/LogEventData.kt	100.00% <100.00%> (ø)
...droid/embracesdk/arch/destination/SpanEventData.kt	100.00% <100.00%> (ø)
...droid/embracesdk/arch/destination/StartSpanData.kt	75.00% <100.00%> (ø)
...roid/embracesdk/arch/schema/AppTerminationCause.kt	100.00% <100.00%> (ø)
...android/embracesdk/arch/schema/EmbraceAttribute.kt	100.00% <100.00%> (ø)
...droid/embracesdk/arch/schema/ErrorCodeAttribute.kt	100.00% <100.00%> (ø)
.../embrace/android/embracesdk/arch/schema/KeySpan.kt	100.00% <100.00%> (ø)
...race/android/embracesdk/arch/schema/PrivateSpan.kt	100.00% <100.00%> (ø)
...id/embracesdk/internal/spans/CurrentSessionSpan.kt	100.00% <100.00%> (ø)
...mbracesdk/internal/spans/CurrentSessionSpanImpl.kt	90.24% <100.00%> (-0.46%)	⬇️
... and 9 more

... and 4 files with indirect coverage changes

[bidetofevil]

Merge activity

• Mar 11, 11:26 AM EDT: @bidetofevil started a stack merge that includes this pull request via Graphite.
• Mar 11, 11:35 AM EDT: Graphite rebased this pull request as part of a merge.
• Mar 11, 11:36 AM EDT: @bidetofevil merged this pull request with Graphite.