-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in extension functions useful when working with EmbraceAttributes #533
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @bidetofevil and the rest of your teammates on Graphite |
ef72803
to
0f97f66
Compare
480b5a0
to
afdf4a0
Compare
0f97f66
to
c5654b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #533 +/- ##
==========================================
+ Coverage 79.45% 79.54% +0.08%
==========================================
Files 403 407 +4
Lines 10861 10870 +9
Branches 1602 1602
==========================================
+ Hits 8630 8646 +16
+ Misses 1585 1578 -7
Partials 646 646
|
Merge activity
|
afdf4a0
to
c526787
Compare
c5654b8
to
587bfd3
Compare
Goal
Add and use extension functions to test EmbraceAttributes values within generated data
Note: I accidentally merged in a commit that converts
emb.key
to an EmbraceAttribute, and since the changes were intermingled in the same file..... I'm just going to leave it and apologize 😅Testing
Existing test cover this