Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in extension functions useful when working with EmbraceAttributes #533

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Mar 9, 2024

Goal

Add and use extension functions to test EmbraceAttributes values within generated data

Note: I accidentally merged in a commit that converts emb.key to an EmbraceAttribute, and since the changes were intermingled in the same file..... I'm just going to leave it and apologize 😅

Testing

Existing test cover this

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 95.91837% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 79.54%. Comparing base (5e18d90) to head (c5654b8).
Report is 19 commits behind head on master.

❗ Current head c5654b8 differs from pull request most recent head 587bfd3. Consider uploading reports for the commit 587bfd3 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #533      +/-   ##
==========================================
+ Coverage   79.45%   79.54%   +0.08%     
==========================================
  Files         403      407       +4     
  Lines       10861    10870       +9     
  Branches     1602     1602              
==========================================
+ Hits         8630     8646      +16     
+ Misses       1585     1578       -7     
  Partials      646      646              
Files Coverage Δ
...ndroid/embracesdk/arch/destination/LogEventData.kt 100.00% <100.00%> (ø)
...droid/embracesdk/arch/destination/SpanEventData.kt 100.00% <100.00%> (ø)
...droid/embracesdk/arch/destination/StartSpanData.kt 75.00% <100.00%> (ø)
...roid/embracesdk/arch/schema/AppTerminationCause.kt 100.00% <100.00%> (ø)
...android/embracesdk/arch/schema/EmbraceAttribute.kt 100.00% <100.00%> (ø)
...droid/embracesdk/arch/schema/ErrorCodeAttribute.kt 100.00% <100.00%> (ø)
.../embrace/android/embracesdk/arch/schema/KeySpan.kt 100.00% <100.00%> (ø)
...id/embracesdk/internal/spans/CurrentSessionSpan.kt 100.00% <100.00%> (ø)
...mbracesdk/internal/spans/CurrentSessionSpanImpl.kt 90.24% <100.00%> (-0.46%) ⬇️
...oid/embracesdk/internal/spans/EmbraceExtensions.kt 92.98% <100.00%> (+0.67%) ⬆️
... and 8 more

... and 5 files with indirect coverage changes

Copy link
Collaborator Author

bidetofevil commented Mar 11, 2024

Merge activity

  • Mar 11, 11:26 AM EDT: @bidetofevil started a stack merge that includes this pull request via Graphite.
  • Mar 11, 11:33 AM EDT: Graphite rebased this pull request as part of a merge.
  • Mar 11, 11:34 AM EDT: @bidetofevil merged this pull request with Graphite.

Base automatically changed from hho/wip-emb-attr to master March 11, 2024 15:32
@bidetofevil bidetofevil merged commit 7c19640 into master Mar 11, 2024
2 of 3 checks passed
@bidetofevil bidetofevil deleted the hho/attribute-extentions branch March 11, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants