Add session and key name to EmbType and TelemetryType respectively

[bidetofevil]

Goal

Add Session to the list of ux subtypes and also a method to get the key name it should used when put inside of OTel signals

[bidetofevil]

• Convert private span attribute to EmbraceAttributes #534
• Add in extension functions useful when working with EmbraceAttributes #533
• Make EmbType a TelemetryType and make TelemetryType an EmbraceAttribute #531
• Refactor how Embrace attributes are defined #526
• Delete EmbraceAttributes.Type and consolidate on EmbType #525
• Add session and key name to EmbType and TelemetryType respectively #524 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on Graphite

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 79.46%. Comparing base (0015c2e) to head (b69df7b).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #524      +/-   ##
==========================================
- Coverage   79.47%   79.46%   -0.02%     
==========================================
  Files         403      403              
  Lines       10857    10859       +2     
  Branches     1600     1600              
==========================================
  Hits         8629     8629              
- Misses       1583     1585       +2     
  Partials      645      645              

Files	Coverage Δ
.../embrace/android/embracesdk/arch/schema/EmbType.kt	66.66% <0.00%> (-13.34%)	⬇️

[fractalwrench]

I'm not 100% on how this would be used. Does an EmbraceAttribute call this, and why is the value prefixed with type? An example is probably all I need to grok this

[bidetofevil]

The attributeName is the key name used in the attributes map. The next PR should clarify this - eventually I'll merge this in with the EmbraceAttribute stuff and I think it'll make more sense.

[fractalwrench]

LGTM

[bidetofevil]

Merge activity

• Mar 11, 11:26 AM EDT: @bidetofevil started a stack merge that includes this pull request via Graphite.
• Mar 11, 11:26 AM EDT: @bidetofevil merged this pull request with Graphite.