Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete EmbraceAttributes.Type and consolidate on EmbType #525

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Mar 7, 2024

Goal

Replace the use of EmbraceAttributes.Type with TelemetryType

Testing

Covered by existing tests

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.48%. Comparing base (5e18d90) to head (76865c0).
Report is 13 commits behind head on master.

❗ Current head 76865c0 differs from pull request most recent head e3c84d8. Consider uploading reports for the commit e3c84d8 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #525      +/-   ##
==========================================
+ Coverage   79.45%   79.48%   +0.02%     
==========================================
  Files         403      403              
  Lines       10861    10855       -6     
  Branches     1602     1600       -2     
==========================================
- Hits         8630     8628       -2     
+ Misses       1585     1582       -3     
+ Partials      646      645       -1     
Files Coverage Δ
...mbracesdk/internal/spans/CurrentSessionSpanImpl.kt 90.69% <100.00%> (ø)
...oid/embracesdk/internal/spans/EmbraceExtensions.kt 91.80% <100.00%> (-0.51%) ⬇️
...id/embracesdk/internal/spans/EmbraceSpanService.kt 94.28% <ø> (ø)
...e/android/embracesdk/internal/spans/SpanService.kt 96.29% <100.00%> (ø)
...droid/embracesdk/internal/spans/SpanServiceImpl.kt 100.00% <ø> (ø)
...esdk/internal/spans/UninitializedSdkSpanService.kt 76.66% <100.00%> (ø)

... and 4 files with indirect coverage changes

Copy link
Collaborator Author

bidetofevil commented Mar 11, 2024

Merge activity

  • Mar 11, 11:26 AM EDT: @bidetofevil started a stack merge that includes this pull request via Graphite.
  • Mar 11, 11:27 AM EDT: Graphite rebased this pull request as part of a merge.
  • Mar 11, 11:28 AM EDT: @bidetofevil merged this pull request with Graphite.

Base automatically changed from hho/add-to-embtype to master March 11, 2024 15:26
@bidetofevil bidetofevil force-pushed the hho/remove-embraceattributes-type branch from 76865c0 to e3c84d8 Compare March 11, 2024 15:27
@bidetofevil bidetofevil merged commit 1a4f08b into master Mar 11, 2024
2 of 3 checks passed
@bidetofevil bidetofevil deleted the hho/remove-embraceattributes-type branch March 11, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants