-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete EmbraceAttributes.Type and consolidate on EmbType #525
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @bidetofevil and the rest of your teammates on |
be41250
to
d699687
Compare
6bf6ba2
to
a6357b5
Compare
d699687
to
a70cb16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a6357b5
to
91f0692
Compare
a70cb16
to
894c375
Compare
91f0692
to
b69df7b
Compare
894c375
to
76865c0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #525 +/- ##
==========================================
+ Coverage 79.45% 79.48% +0.02%
==========================================
Files 403 403
Lines 10861 10855 -6
Branches 1602 1600 -2
==========================================
- Hits 8630 8628 -2
+ Misses 1585 1582 -3
+ Partials 646 645 -1
|
Merge activity
|
76865c0
to
e3c84d8
Compare
Goal
Replace the use of EmbraceAttributes.Type with TelemetryType
Testing
Covered by existing tests