Refactor how Embrace attributes are defined

[bidetofevil]

Goal

Create an abstraction for an Embrace Attribute and define a sealed class for each attribute and an implementation of that class for each valid value.

I converted two attributes just to get some feedback as to whether this is a good idea/implementation. If it looks good, I can convert EmbType/TelemetryType to this format as well.

The goal is to be able to use these class when validating values in tests, and also when we write out the property to OTel objects, instead of having to hardcode rules like putting emb. in front of attribute names, etc.

If this looks good, I'll add convenience methods to internal objects and tests to simply the code that words with Embrace attributes, so you can do something like span.setEmbraceAttribute(ErrorCode.Failure)

Testing

Existing tests cover the usage, but unit tests should be added to test the abstract classes if this is deemed a good way to go.

[bidetofevil]

• Convert private span attribute to EmbraceAttributes #534
• Add in extension functions useful when working with EmbraceAttributes #533
• Make EmbType a TelemetryType and make TelemetryType an EmbraceAttribute #531
• Refactor how Embrace attributes are defined #526 👈
• Delete EmbraceAttributes.Type and consolidate on EmbType #525
• Add session and key name to EmbType and TelemetryType respectively #524
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on Graphite

[bidetofevil]

This is marked as @BetaApi so I think this change is OK, especially given that customers shouldn't be using those methods anyway.

[fractalwrench]

LGTM

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.59%. Comparing base (5e18d90) to head (92e8c37).
Report is 15 commits behind head on master.

❗ Current head 92e8c37 differs from pull request most recent head 61848e4. Consider uploading reports for the commit 61848e4 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #526      +/-   ##
==========================================
+ Coverage   79.45%   79.59%   +0.14%     
==========================================
  Files         403      406       +3     
  Lines       10861    10867       +6     
  Branches     1602     1601       -1     
==========================================
+ Hits         8630     8650      +20     
+ Misses       1585     1575      -10     
+ Partials      646      642       -4     

Files	Coverage Δ
...roid/embracesdk/arch/schema/AppTerminationCause.kt	100.00% <100.00%> (ø)
...android/embracesdk/arch/schema/EmbraceAttribute.kt	100.00% <100.00%> (ø)
...droid/embracesdk/arch/schema/ErrorCodeAttribute.kt	100.00% <100.00%> (ø)
...id/embracesdk/internal/spans/CurrentSessionSpan.kt	100.00% <100.00%> (ø)
...mbracesdk/internal/spans/CurrentSessionSpanImpl.kt	90.69% <100.00%> (ø)
...oid/embracesdk/internal/spans/EmbraceExtensions.kt	93.10% <100.00%> (+0.79%)	⬆️
...id/embracesdk/internal/spans/EmbraceSpanService.kt	94.28% <ø> (ø)
...e/android/embracesdk/internal/spans/SpanService.kt	96.29% <100.00%> (ø)
...droid/embracesdk/internal/spans/SpanServiceImpl.kt	100.00% <ø> (ø)
...esdk/internal/spans/UninitializedSdkSpanService.kt	76.66% <100.00%> (ø)
... and 2 more

... and 7 files with indirect coverage changes

[bidetofevil]

Merge activity

• Mar 11, 11:26 AM EDT: @bidetofevil started a stack merge that includes this pull request via Graphite.
• Mar 11, 11:29 AM EDT: Graphite rebased this pull request as part of a merge.
• Mar 11, 11:30 AM EDT: @bidetofevil merged this pull request with Graphite.