Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove react_native_version from EnvelopeResource #517

Merged

Conversation

nelsitoPuglisi
Copy link
Contributor

@nelsitoPuglisi nelsitoPuglisi commented Mar 6, 2024

Goal

hosted_platform_version will be used for every hosted sdk.

Copy link
Contributor Author

nelsitoPuglisi commented Mar 6, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nelsitoPuglisi and the rest of your teammates on Graphite Graphite

@nelsitoPuglisi nelsitoPuglisi force-pushed the nelson/envelope-without-rn-version branch from 4cccbc8 to 5cc97b0 Compare March 6, 2024 20:54
@nelsitoPuglisi nelsitoPuglisi changed the title remove react_native_version Remove react_native_version from EnvelopeResource Mar 6, 2024
@nelsitoPuglisi nelsitoPuglisi force-pushed the nelson/envelope-without-rn-version branch 3 times, most recently from bcb4791 to ca681cd Compare March 6, 2024 21:39
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nelsitoPuglisi nelsitoPuglisi force-pushed the nelson/envelope-without-rn-version branch from 4a0c8e9 to e4cb0ab Compare March 11, 2024 18:16
@nelsitoPuglisi nelsitoPuglisi merged commit e4cb0ab into nelson/envelope-resource Mar 12, 2024
0 of 2 checks passed
@nelsitoPuglisi nelsitoPuglisi deleted the nelson/envelope-without-rn-version branch March 12, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants