Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes unused reference to ActivityManager from EmbraceMetadataService #515

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

nelsitoPuglisi
Copy link
Contributor

@nelsitoPuglisi nelsitoPuglisi commented Mar 6, 2024

Goal

  • Removes unused reference to ActivityManager in EmbraceMetadataService
  • Removes mockActivityManager as it's not used anymore.

Testing

Unit tests

@nelsitoPuglisi nelsitoPuglisi requested a review from a team as a code owner March 6, 2024 20:48
Copy link
Contributor Author

nelsitoPuglisi commented Mar 6, 2024

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.35%. Comparing base (4c3ec09) to head (db08722).

Additional details and impacted files

Impacted file tree graph

@@                      Coverage Diff                       @@
##           nelson/useless-memory-test     #515      +/-   ##
==============================================================
- Coverage                       79.36%   79.35%   -0.01%     
==============================================================
  Files                             387      387              
  Lines                           10563    10561       -2     
  Branches                         1571     1571              
==============================================================
- Hits                             8383     8381       -2     
- Misses                           1548     1549       +1     
+ Partials                          632      631       -1     
Files Coverage Δ
...racesdk/capture/metadata/EmbraceMetadataService.kt 87.85% <ø> (-0.04%) ⬇️
...oid/embracesdk/injection/EssentialServiceModule.kt 95.58% <ø> (-0.04%) ⬇️

... and 2 files with indirect coverage changes

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from nelson/useless-memory-test to master March 7, 2024 09:07
@nelsitoPuglisi nelsitoPuglisi merged commit 81e1735 into master Mar 7, 2024
4 checks passed
@nelsitoPuglisi nelsitoPuglisi deleted the nelson/remove-unused-activity-manager branch March 7, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants