Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New app environment enum #613

Merged
merged 1 commit into from
Mar 22, 2024
Merged

New app environment enum #613

merged 1 commit into from
Mar 22, 2024

Conversation

nelsitoPuglisi
Copy link
Contributor

@nelsitoPuglisi nelsitoPuglisi commented Mar 21, 2024

Goal

Move away from static MetadataUtils and centralize AppEnvironment as enum

Testing

UnitTest

Copy link
Contributor Author

nelsitoPuglisi commented Mar 21, 2024

@nelsitoPuglisi nelsitoPuglisi changed the title new app environment enum New app environment enum Mar 21, 2024
@nelsitoPuglisi nelsitoPuglisi marked this pull request as ready for review March 21, 2024 18:51
@nelsitoPuglisi nelsitoPuglisi requested a review from a team as a code owner March 21, 2024 18:51
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.62%. Comparing base (f1752cf) to head (aed8380).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #613      +/-   ##
==========================================
+ Coverage   80.49%   80.62%   +0.13%     
==========================================
  Files         415      416       +1     
  Lines       11149    11155       +6     
  Branches     1640     1640              
==========================================
+ Hits         8974     8994      +20     
+ Misses       1518     1506      -12     
+ Partials      657      655       -2     
Files Coverage Δ
...roid/embracesdk/capture/metadata/AppEnvironment.kt 100.00% <100.00%> (ø)
...racesdk/capture/metadata/EmbraceMetadataService.kt 87.90% <100.00%> (ø)
...oid/embracesdk/capture/metadata/MetadataUtils.java 57.69% <ø> (+1.08%) ⬆️
...embrace/android/embracesdk/injection/CoreModule.kt 72.22% <100.00%> (+3.80%) ⬆️
...oid/embracesdk/injection/EssentialServiceModule.kt 95.77% <100.00%> (+0.02%) ⬆️

... and 4 files with indirect coverage changes

Copy link
Contributor

@lucaslabari lucaslabari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nelsitoPuglisi nelsitoPuglisi merged commit ec2a330 into master Mar 22, 2024
6 checks passed
@nelsitoPuglisi nelsitoPuglisi deleted the nelson/app-environment branch March 22, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants