Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populates EnvelopeResource #516

Merged
merged 32 commits into from
Mar 22, 2024
Merged

Populates EnvelopeResource #516

merged 32 commits into from
Mar 22, 2024

Conversation

nelsitoPuglisi
Copy link
Contributor

@nelsitoPuglisi nelsitoPuglisi commented Mar 6, 2024

Goal

Populates the envelope.resource field, without using MetadataService.

Note: MetadataService is still used because of reactNativeBundleId which will be refactored in a subsequent PR.

@nelsitoPuglisi nelsitoPuglisi requested a review from a team as a code owner March 6, 2024 20:48
Copy link
Contributor Author

nelsitoPuglisi commented Mar 6, 2024

Base automatically changed from nelson/remove-unused-activity-manager to master March 7, 2024 09:08
@nelsitoPuglisi nelsitoPuglisi force-pushed the nelson/envelope-resource branch 2 times, most recently from 0eee472 to e22a959 Compare March 11, 2024 18:02
@nelsitoPuglisi nelsitoPuglisi marked this pull request as ready for review March 11, 2024 18:08
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments inline - also it looks like there are some compilation issues on CI?

@nelsitoPuglisi nelsitoPuglisi marked this pull request as draft March 12, 2024 13:35
@nelsitoPuglisi nelsitoPuglisi force-pushed the nelson/envelope-resource branch 2 times, most recently from 9b15aee to 1b7bcfb Compare March 21, 2024 18:50
@nelsitoPuglisi nelsitoPuglisi changed the base branch from master to nelson/app-environment March 21, 2024 18:50
@nelsitoPuglisi nelsitoPuglisi marked this pull request as ready for review March 21, 2024 18:58
Copy link
Contributor

@lucaslabari lucaslabari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 75.18248% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 80.41%. Comparing base (ec2a330) to head (d87770b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #516      +/-   ##
==========================================
- Coverage   80.55%   80.41%   -0.15%     
==========================================
  Files         416      417       +1     
  Lines       11155    11279     +124     
  Branches     1640     1661      +21     
==========================================
+ Hits         8986     9070      +84     
- Misses       1512     1549      +37     
- Partials      657      660       +3     
Files Coverage Δ
...d/embracesdk/capture/cpu/EmbraceCpuInfoDelegate.kt 20.00% <ø> (ø)
...oid/embracesdk/capture/metadata/MetadataService.kt 100.00% <ø> (ø)
...oid/embracesdk/injection/EssentialServiceModule.kt 93.66% <100.00%> (-2.12%) ⬇️
...oid/embracesdk/injection/ModuleInitBootstrapper.kt 94.69% <100.00%> (+0.08%) ⬆️
...race/android/embracesdk/injection/PayloadModule.kt 100.00% <100.00%> (ø)
...id/embracesdk/internal/payload/EnvelopeResource.kt 100.00% <100.00%> (ø)
...embrace/android/embracesdk/injection/CoreModule.kt 68.42% <0.00%> (-3.81%) ⬇️
...racesdk/capture/metadata/EmbraceMetadataService.kt 87.27% <33.33%> (-0.63%) ⬇️
...re/envelope/resource/EnvelopeResourceSourceImpl.kt 84.37% <84.37%> (-15.63%) ⬇️
...oid/embracesdk/capture/envelope/resource/Device.kt 63.88% <63.88%> (ø)

... and 5 files with indirect coverage changes

Base automatically changed from nelson/app-environment to master March 22, 2024 16:18
@nelsitoPuglisi nelsitoPuglisi merged commit 8f71461 into master Mar 22, 2024
4 checks passed
@nelsitoPuglisi nelsitoPuglisi deleted the nelson/envelope-resource branch March 22, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants