-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Populates EnvelopeResource #516
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @nelsitoPuglisi and the rest of your teammates on |
804b0b5
to
ae338f4
Compare
...n/java/io/embrace/android/embracesdk/capture/envelope/resource/EnvelopeResourceSourceImpl.kt
Outdated
Show resolved
Hide resolved
...android-sdk/src/main/java/io/embrace/android/embracesdk/internal/payload/EnvelopeResource.kt
Outdated
Show resolved
Hide resolved
0eee472
to
e22a959
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments inline - also it looks like there are some compilation issues on CI?
...n/java/io/embrace/android/embracesdk/capture/envelope/resource/EnvelopeResourceSourceImpl.kt
Show resolved
Hide resolved
...n/java/io/embrace/android/embracesdk/capture/envelope/resource/EnvelopeResourceSourceImpl.kt
Outdated
Show resolved
Hide resolved
...n/java/io/embrace/android/embracesdk/capture/envelope/resource/EnvelopeResourceSourceImpl.kt
Outdated
Show resolved
Hide resolved
...android-sdk/src/main/java/io/embrace/android/embracesdk/internal/payload/EnvelopeResource.kt
Outdated
Show resolved
Hide resolved
9b15aee
to
1b7bcfb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...-android-sdk/src/main/java/io/embrace/android/embracesdk/capture/envelope/resource/Device.kt
Outdated
Show resolved
Hide resolved
...-android-sdk/src/main/java/io/embrace/android/embracesdk/capture/envelope/resource/Device.kt
Outdated
Show resolved
Hide resolved
...android-sdk/src/main/java/io/embrace/android/embracesdk/internal/payload/EnvelopeResource.kt
Show resolved
Hide resolved
...n/java/io/embrace/android/embracesdk/capture/envelope/resource/EnvelopeResourceSourceImpl.kt
Show resolved
Hide resolved
2b3024e
to
aed8380
Compare
1b7bcfb
to
610ca4b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #516 +/- ##
==========================================
- Coverage 80.55% 80.41% -0.15%
==========================================
Files 416 417 +1
Lines 11155 11279 +124
Branches 1640 1661 +21
==========================================
+ Hits 8986 9070 +84
- Misses 1512 1549 +37
- Partials 657 660 +3
|
…k/internal/payload/EnvelopeResource.kt Co-authored-by: Jamie Lynch <[email protected]>
610ca4b
to
0d733ae
Compare
Goal
Populates the
envelope.resource
field, without using MetadataService.Note: MetadataService is still used because of reactNativeBundleId which will be refactored in a subsequent PR.