Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless MemoryService tests #514

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

nelsitoPuglisi
Copy link
Contributor

@nelsitoPuglisi nelsitoPuglisi commented Mar 6, 2024

Goal

  • Remove ActivityManager as it wasn't used in the tests.
  • Remove tests that are just not testing production code.

Testing

Unit tests passing.

@nelsitoPuglisi nelsitoPuglisi requested a review from a team as a code owner March 6, 2024 20:48
Copy link
Contributor Author

nelsitoPuglisi commented Mar 6, 2024

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.36%. Comparing base (af3a090) to head (4c3ec09).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #514      +/-   ##
==========================================
+ Coverage   79.31%   79.36%   +0.04%     
==========================================
  Files         387      387              
  Lines       10563    10563              
  Branches     1571     1571              
==========================================
+ Hits         8378     8383       +5     
+ Misses       1551     1548       -3     
+ Partials      634      632       -2     

see 2 files with indirect coverage changes

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nelsitoPuglisi nelsitoPuglisi merged commit fbe7bb8 into master Mar 7, 2024
5 checks passed
@nelsitoPuglisi nelsitoPuglisi deleted the nelson/useless-memory-test branch March 7, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants