-
Notifications
You must be signed in to change notification settings - Fork 7
Permalink
Loading
Choose a base ref
{{ refName }}
default
Loading
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: embrace-io/embrace-android-sdk
base: 2937366
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: embrace-io/embrace-android-sdk
compare: 66a3f67
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 7 commits
- 26 files changed
- 1 contributor
Commits on Apr 18, 2024
-
Initial prep for sending network requests as spans (#745)
## Goal This is the initial PR for sending network requests as spans. - Removed recordAndDeduplicateNetworkRequest. This was used in HttpURLConnectionDelegate to avoid logging network requests with the same call ID. It is still required, but we will address it differently in the following PRs. For now, we will use the same method as the rest of the requests. - logNetworkError and logNetworkCall did essentially the same. We will move that logic to the logging service so we don't bloat EmbraceImpl - getNetworkCallsSnapshot won't be used anymore, as we will record spans directly when they get to the logging service. We won't need to expose them when the session ends. - Stop looking for network logs in PerformanceInfo. Removed "nr" from session-end.json. We won't be sending network requests there anymore. - Updated tests to use the new APIs
Configuration menu - View commit details
-
Copy full SHA for 2c3bd85 - Browse repository at this point
Copy the full SHA 2c3bd85View commit details -
Remove getNetworkCallsSnapshot, as we won't be using it anymore (#746)
## Goal Delete getNetworkCallsSnapshot, and some private variables used by it.
Configuration menu - View commit details
-
Copy full SHA for 95d37b7 - Browse repository at this point
Copy the full SHA 95d37b7View commit details -
Added a SchemaType for mapping an EmbraceNetworkRequest to OTel compl…
…iant attributes (#747) ## Goal This will be used in EmbraceNetworkLoggingService to map from an EmbraceNetworkRequest to the correct span attributes. We verified with backend that removing null attributes would cause no issues, so we are using toNonNullMap()
Configuration menu - View commit details
-
Copy full SHA for dab7985 - Browse repository at this point
Copy the full SHA dab7985View commit details -
Record logged network requests as completed spans (#748)
- Record network requests as spans. - Consolidate logNetworkCall and logNetworkError methods EmbraceNetworkLoggingService had two methods: logNetworkCall and logNetworkError. They were both doing essentially the same, but with a different NetworkCallV2 object: strip the URL, sanitize the TraceId, logging the networkCapturedData, and processing the network call. We don't need a NetworkCallV2 object anymore, and the EmbraceNetworkRequest is the same for both network call and network error, so we can just use one method. - Remove unused methods. ### Questions: - Why do we need to strip the URL? - Why are we stripping the URL for the span, but not for the networkCapturedData?
Configuration menu - View commit details
-
Copy full SHA for 93f6b0b - Browse repository at this point
Copy the full SHA 93f6b0bView commit details
Commits on Apr 19, 2024
-
Moved the logic for counting domain limits to a new class (#749)
## Goal Extracted the logic for counting domain limits to another class. This will allow us to test it more thoroughly in the future, as we detected some inconsistencies. It also keeps the NetworkLogging service cleaner. ### Questions: - Shouldn't we ignore domains that can't be parsed for networkCapturedData too? - Shouldn't we also track limits for networkCapturedData? - Should we synchronize on another object now that we don't use callsStorageLastUpdate? - All of the IP address domains fall under the same limit? Is that correct?
Configuration menu - View commit details
-
Copy full SHA for 9da6934 - Browse repository at this point
Copy the full SHA 9da6934View commit details -
Fixed tests for EmbraceNetworkLoggingService (#755)
## Goal Added unit tests for EmbraceNetworkLoggingService Many of the existing tests will be moved to the DomainCountLimiter tests in a following PR
Configuration menu - View commit details
-
Copy full SHA for b153a68 - Browse repository at this point
Copy the full SHA b153a68View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66a3f67 - Browse repository at this point
Copy the full SHA 66a3f67View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 2937366...66a3f67