Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: embrace-io/embrace-android-sdk Loading
base: 2937366
Choose a base ref
...
head repository: embrace-io/embrace-android-sdk Loading
compare: 66a3f67
Choose a head ref
  • 7 commits
  • 26 files changed
  • 1 contributor

Commits on Apr 18, 2024

  1. Initial prep for sending network requests as spans (#745)

    ## Goal
    
    This is the initial PR for sending network requests as spans. 
    
    - Removed recordAndDeduplicateNetworkRequest. 
    
    This was used in HttpURLConnectionDelegate to avoid logging network requests with the same call ID. It is still required, but we will address it differently in the following PRs. For now, we will use the same method as the rest of the requests.
    
    - logNetworkError and logNetworkCall did essentially the same. We will move that logic to the logging service so we don't bloat EmbraceImpl
    
    - getNetworkCallsSnapshot won't be used anymore, as we will record spans directly when they get to the logging service. We won't need to expose them when the session ends.
    
    - Stop looking for network logs in PerformanceInfo. Removed "nr" from session-end.json. We won't be sending network requests there anymore.
    
    - Updated tests to use the new APIs
    priettt committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    2c3bd85 View commit details
    Browse the repository at this point in the history
  2. Remove getNetworkCallsSnapshot, as we won't be using it anymore (#746)

    ## Goal
    
    Delete getNetworkCallsSnapshot, and some private variables used by it.
    priettt committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    95d37b7 View commit details
    Browse the repository at this point in the history
  3. Added a SchemaType for mapping an EmbraceNetworkRequest to OTel compl…

    …iant attributes (#747)
    
    ## Goal
    
    This will be used in EmbraceNetworkLoggingService to map from an EmbraceNetworkRequest to the correct span attributes.
    
    We verified with backend that removing null attributes would cause no issues, so we are using toNonNullMap()
    priettt committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    dab7985 View commit details
    Browse the repository at this point in the history
  4. Record logged network requests as completed spans (#748)

    - Record network requests as spans.
    
    - Consolidate logNetworkCall and logNetworkError methods
    
    EmbraceNetworkLoggingService had two methods: logNetworkCall and logNetworkError. They were both doing essentially the same, but with a different NetworkCallV2 object: strip the URL, sanitize the TraceId, logging the networkCapturedData, and processing the network call.
    
    We don't need a NetworkCallV2 object anymore, and the EmbraceNetworkRequest is the same for both network call and network error, so we can just use one method.
    
    - Remove unused methods.
    
    ### Questions:
    - Why do we need to strip the URL? 
    - Why are we stripping the URL for the span, but not for the networkCapturedData?
    priettt committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    93f6b0b View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Moved the logic for counting domain limits to a new class (#749)

    ## Goal
    
    Extracted the logic for counting domain limits to another class. This will allow us to test it more thoroughly in the future, as we detected some inconsistencies. It also keeps the NetworkLogging service cleaner. 
    
    ### Questions: 
    - Shouldn't we ignore domains that can't be parsed for networkCapturedData too?
    - Shouldn't we also track limits for networkCapturedData?
    - Should we synchronize on another object now that we don't use callsStorageLastUpdate?
    - All of the IP address domains fall under the same limit? Is that correct?
    priettt committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    9da6934 View commit details
    Browse the repository at this point in the history
  2. Fixed tests for EmbraceNetworkLoggingService (#755)

    ## Goal
    
    Added unit tests for EmbraceNetworkLoggingService
    
    Many of the existing tests will be moved to the DomainCountLimiter tests in a following PR
    priettt committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    b153a68 View commit details
    Browse the repository at this point in the history
  3. Fixed tests for DomainCountLimiter

    priettt authored and bidetofevil committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    66a3f67 View commit details
    Browse the repository at this point in the history
Loading