Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo build #1296

Merged
merged 5 commits into from
Dec 19, 2018
Merged

Cargo build #1296

merged 5 commits into from
Dec 19, 2018

Conversation

piscisaureus
Copy link
Member

Windows works more or less.
Linux is stuck on libc++.
Haven't done any testing on mac yet.

@piscisaureus piscisaureus force-pushed the cargo_build branch 3 times, most recently from 9b1d5aa to 0aea20c Compare December 10, 2018 18:23
ry
ry reviewed Dec 10, 2018
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Was able to build on Linux (had to delete Cargo.lock first tho)

libdeno/BUILD.gn Outdated Show resolved Hide resolved
libdeno/BUILD.gn Outdated Show resolved Hide resolved
@piscisaureus piscisaureus force-pushed the cargo_build branch 3 times, most recently from 3e02970 to 3320335 Compare December 11, 2018 02:07
@ry ry mentioned this pull request Dec 11, 2018
Closed
@piscisaureus piscisaureus force-pushed the cargo_build branch 2 times, most recently from 5d05542 to 7481d87 Compare December 13, 2018 21:19
ry
ry reviewed Dec 13, 2018
View reviewed changes
BUILD.gn Outdated Show resolved Hide resolved
ry
ry reviewed Dec 13, 2018
View reviewed changes
build.rs Outdated Show resolved Hide resolved
ry
ry reviewed Dec 13, 2018
View reviewed changes
libdeno/BUILD.gn Outdated Show resolved Hide resolved
ry
ry reviewed Dec 13, 2018
View reviewed changes
libdeno/BUILD.gn Show resolved Hide resolved
ry
ry reviewed Dec 13, 2018
View reviewed changes
tools/setup.py Outdated Show resolved Hide resolved
@ry
Copy link
Member

ry commented Dec 13, 2018 •
edited

Although I can't see this anywhere on github's interface, it seems the build submodule has this comment in it:

commit 782d7965f05713f1dea713d32c9f93ae9ae69524 (HEAD, origin/20181211_cargo_build_2)
Author: Bert Belder <[email protected]>
Date:   Tue Dec 11 02:11:12 2018 +0100

    temp workaround

Which I think we don't need anymore.

nevermind

ry
ry reviewed Dec 13, 2018
View reviewed changes
.gn Outdated Show resolved Hide resolved
@piscisaureus piscisaureus force-pushed the cargo_build branch 6 times, most recently from 73f3c25 to 40fd1eb Compare December 19, 2018 11:14
@piscisaureus piscisaureus changed the title WIP: cargo build Cargo build Dec 19, 2018
@piscisaureus
Copy link
Member Author

@ry ptal

ry
ry approved these changes Dec 19, 2018
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/

LGTM

libdeno/BUILD.gn Show resolved Hide resolved
@piscisaureus piscisaureus merged commit 0ff5aa0 into denoland:master Dec 19, 2018
@piscisaureus piscisaureus deleted the cargo_build branch December 19, 2018 17:52
ry added a commit to ry/deno that referenced this pull request Dec 23, 2018
@ry
v0.2.4
74d0e6f 
- Upgrade V8 to 7.2.502.16 (denoland#1403)
- Remove support for extensionless import  (denoland#1396)
- make stdout unbuffered (denoland#1355)
- Implement `Body.formData` for fetch (denoland#1393)
- Improve handling of non-coercable objects in assertEqual (denoland#1385)
- Avoid fetch segfault on empty Uri (denoland#1394)
- Expose deno.inspect (denoland#1378)
- "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379)
- Add illegal header name and value guards (denoland#1375)
- Fix URLSearchParams set() and constructor() (denoland#1368)
- Remove prebuilt v8 support (denoland#1369)
- Enable jumbo build in release. (denoland#1362)
- Add URL implementation (denoland#1359)
- Add console.count and console.time (denoland#1358)
@ry ry mentioned this pull request Dec 23, 2018
Merged
ry added a commit to ry/deno that referenced this pull request Dec 23, 2018
@ry
v0.2.4
e130b4f 
- Upgrade V8 to 7.2.502.16 (denoland#1403)
- Remove support for extensionless import  (denoland#1396)
- make stdout unbuffered (denoland#1355)
- Implement `Body.formData` for fetch (denoland#1393)
- Improve handling of non-coercable objects in assertEqual (denoland#1385)
- Avoid fetch segfault on empty Uri (denoland#1394)
- Expose deno.inspect (denoland#1378)
- "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379)
- Add illegal header name and value guards (denoland#1375)
- Fix URLSearchParams set() and constructor() (denoland#1368)
- Remove prebuilt v8 support (denoland#1369)
- Enable jumbo build in release. (denoland#1362)
- Add URL implementation (denoland#1359)
- Add console.count and console.time (denoland#1358)
ry added a commit to ry/deno that referenced this pull request Dec 23, 2018
@ry
v0.2.4
af9f292 
- Upgrade V8 to 7.2.502.16 (denoland#1403)
- Remove support for extensionless import  (denoland#1396)
- make stdout unbuffered (denoland#1355)
- Implement `Body.formData` for fetch (denoland#1393)
- Improve handling of non-coercable objects in assertEqual (denoland#1385)
- Avoid fetch segfault on empty Uri (denoland#1394)
- Expose deno.inspect (denoland#1378)
- "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379)
- Add illegal header name and value guards (denoland#1375)
- Fix URLSearchParams set() and constructor() (denoland#1368)
- Remove prebuilt v8 support (denoland#1369)
- Enable jumbo build in release. (denoland#1362)
- Add URL implementation (denoland#1359)
- Add console.count and console.time (denoland#1358)
ry added a commit to ry/deno that referenced this pull request Dec 23, 2018
@ry
v0.2.4
4fe72d5 
- Upgrade V8 to 7.2.502.16 (denoland#1403)
- Remove support for extensionless import  (denoland#1396)
- make stdout unbuffered (denoland#1355)
- Implement `Body.formData` for fetch (denoland#1393)
- Improve handling of non-coercable objects in assertEqual (denoland#1385)
- Avoid fetch segfault on empty Uri (denoland#1394)
- Expose deno.inspect (denoland#1378)
- "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379)
- Add illegal header name and value guards (denoland#1375)
- Fix URLSearchParams set() and constructor() (denoland#1368)
- Remove prebuilt v8 support (denoland#1369)
- Enable jumbo build in release. (denoland#1362)
- Add URL implementation (denoland#1359)
- Add console.count and console.time (denoland#1358)
ry added a commit to ry/deno that referenced this pull request Dec 24, 2018
@ry
v0.2.4
9f72238 
- Upgrade V8 to 7.2.502.16 (denoland#1403)
- Remove support for extensionless import  (denoland#1396)
- make stdout unbuffered (denoland#1355)
- Implement `Body.formData` for fetch (denoland#1393)
- Improve handling of non-coercable objects in assertEqual (denoland#1385)
- Avoid fetch segfault on empty Uri (denoland#1394)
- Expose deno.inspect (denoland#1378)
- "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379)
- Add illegal header name and value guards (denoland#1375)
- Fix URLSearchParams set() and constructor() (denoland#1368)
- Remove prebuilt v8 support (denoland#1369)
- Enable jumbo build in release. (denoland#1362)
- Add URL implementation (denoland#1359)
- Add console.count and console.time (denoland#1358)
ry added a commit to ry/deno that referenced this pull request Dec 24, 2018
@ry
v0.2.4
c981f27 
- "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379)
- Remove support for extensionless import (denoland#1396)
- Upgrade V8 to 7.2.502.16 (denoland#1403)
- make stdout unbuffered (denoland#1355)
- Implement `Body.formData` for fetch (denoland#1393)
- Improve handling of non-coercable objects in assertEqual (denoland#1385)
- Avoid fetch segfault on empty Uri (denoland#1394)
- Expose deno.inspect (denoland#1378)
- Add illegal header name and value guards (denoland#1375)
- Fix URLSearchParams set() and constructor() (denoland#1368)
- Remove prebuilt v8 support (denoland#1369)
- Enable jumbo build in release. (denoland#1362)
- Add URL implementation (denoland#1359)
- Add console.count and console.time (denoland#1358)
- runtime arg check `URLSearchParams` (denoland#1390)
ry added a commit to ry/deno that referenced this pull request Dec 24, 2018
@ry
v0.2.4
cac3ebc 
- "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379)
- Remove support for extensionless import (denoland#1396)
- Upgrade V8 to 7.2.502.16 (denoland#1403)
- make stdout unbuffered (denoland#1355)
- Implement `Body.formData` for fetch (denoland#1393)
- Improve handling of non-coercable objects in assertEqual (denoland#1385)
- Avoid fetch segfault on empty Uri (denoland#1394)
- Expose deno.inspect (denoland#1378)
- Add illegal header name and value guards (denoland#1375)
- Fix URLSearchParams set() and constructor() (denoland#1368)
- Remove prebuilt v8 support (denoland#1369)
- Enable jumbo build in release. (denoland#1362)
- Add URL implementation (denoland#1359)
- Add console.count and console.time (denoland#1358)
- runtime arg check `URLSearchParams` (denoland#1390)
ry added a commit that referenced this pull request Dec 24, 2018
@ry
v0.2.4
c6e2fff 
- "cargo build" support (#1369 #1296 #1377 #1379)
- Remove support for extensionless import (#1396)
- Upgrade V8 to 7.2.502.16 (#1403)
- make stdout unbuffered (#1355)
- Implement `Body.formData` for fetch (#1393)
- Improve handling of non-coercable objects in assertEqual (#1385)
- Avoid fetch segfault on empty Uri (#1394)
- Expose deno.inspect (#1378)
- Add illegal header name and value guards (#1375)
- Fix URLSearchParams set() and constructor() (#1368)
- Remove prebuilt v8 support (#1369)
- Enable jumbo build in release. (#1362)
- Add URL implementation (#1359)
- Add console.count and console.time (#1358)
- runtime arg check `URLSearchParams` (#1390)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@piscisaureus @ry