Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to rustc 1.31.0 and rust 2018 #1306

Closed
wants to merge 11 commits into from
Closed

Conversation

hayd
Copy link
Contributor

@hayd hayd commented Dec 11, 2018

cargo check succeeds, but tools/build.py errors out.

@ry
Copy link
Member

ry commented Dec 11, 2018

Cool! But let's wait until #1296 is done.

@hayd
Copy link
Contributor Author

hayd commented Dec 19, 2018

Now cargo build succeeds, but tools/build.py errors out. 😄
Is build.py setting the rust version somehow?

@hayd
Copy link
Contributor Author

hayd commented Dec 23, 2018

It seems like the final stage for this PR is to add args += ["--edition=2018"] in rust.gni BUT only on the deno executable not every crate (since not every crate is edition=2018). Any gn tips for this?

@hayd
Copy link
Contributor Author

hayd commented Dec 23, 2018

Passing an edition flag in gn seems to do the job here, see last commit.

@hayd
Copy link
Contributor Author

hayd commented Dec 23, 2018

RE appveyor fail, I'm not sure how to update rustc... cc @piscisaureus

@hayd hayd changed the title [WIP] Update to rustc 1.31.0 and rust 2018 Update to rustc 1.31.0 and rust 2018 Dec 24, 2018
@hayd
Copy link
Contributor Author

hayd commented Dec 27, 2018

I guess I'll try a few changes to the "rustc exists" appveyor check https://github.com/denoland/deno/pull/1306/files#diff-11c909939117928998b102a1fff7d363L302

I want it to be something like:

- if (-not (Test-Path $env:CARGO_HOME)) {
+ if (-not $(rustc --version | grep 1.31.0)) {

@hayd
Copy link
Contributor Author

hayd commented Jan 4, 2019

I'm not sure what to pass to appveyor in order to bump the version.

Happy to rebase if anyone works out what to put there, or we can bump to 1.31 in another PR then apply rust-2018.

@hayd hayd mentioned this pull request Jan 5, 2019
@ry
Copy link
Member

ry commented Jan 9, 2019

@hayd I'm just closing old PRs. We'd like to upgrade still, of course, but this isn't green. Happy to have a new PR in this direction.

@ry ry closed this Jan 9, 2019
@hayd
Copy link
Contributor Author

hayd commented Jan 9, 2019

@ry yep, this isn't green because I can't bump the rustc version to 1.31 on appveyor.
Once that is updated this is good to go, but it can be another PR.

@hayd hayd mentioned this pull request Jan 14, 2019
@hayd hayd deleted the rust-2018 branch May 24, 2019 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants