Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of non-coercable objects in assertEqual #1385

Merged
merged 1 commit into from
Dec 21, 2018
Merged

Improve handling of non-coercable objects in assertEqual #1385

merged 1 commit into from
Dec 21, 2018

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Dec 21, 2018

Fixes #1382

@kitsonk
Copy link
Contributor Author

kitsonk commented Dec 21, 2018

It appears that the version of tslint we have doesn't properly parse:

try { } catch { }

Where having catch (e) is optional in line with the Stage 4 proposal: https://github.com/tc39/proposal-optional-catch-binding

ry
ry reviewed Dec 21, 2018
View reviewed changes
js/testing/util.ts Show resolved Hide resolved
ry
ry approved these changes Dec 21, 2018
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 317fddb into denoland:master Dec 21, 2018
ry added a commit to ry/deno that referenced this pull request Dec 23, 2018
@ry
v0.2.4
74d0e6f 
- Upgrade V8 to 7.2.502.16 (denoland#1403)
- Remove support for extensionless import  (denoland#1396)
- make stdout unbuffered (denoland#1355)
- Implement `Body.formData` for fetch (denoland#1393)
- Improve handling of non-coercable objects in assertEqual (denoland#1385)
- Avoid fetch segfault on empty Uri (denoland#1394)
- Expose deno.inspect (denoland#1378)
- "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379)
- Add illegal header name and value guards (denoland#1375)
- Fix URLSearchParams set() and constructor() (denoland#1368)
- Remove prebuilt v8 support (denoland#1369)
- Enable jumbo build in release. (denoland#1362)
- Add URL implementation (denoland#1359)
- Add console.count and console.time (denoland#1358)
@ry ry mentioned this pull request Dec 23, 2018
Merged
ry added a commit to ry/deno that referenced this pull request Dec 23, 2018
@ry
v0.2.4
e130b4f 
- Upgrade V8 to 7.2.502.16 (denoland#1403)
- Remove support for extensionless import  (denoland#1396)
- make stdout unbuffered (denoland#1355)
- Implement `Body.formData` for fetch (denoland#1393)
- Improve handling of non-coercable objects in assertEqual (denoland#1385)
- Avoid fetch segfault on empty Uri (denoland#1394)
- Expose deno.inspect (denoland#1378)
- "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379)
- Add illegal header name and value guards (denoland#1375)
- Fix URLSearchParams set() and constructor() (denoland#1368)
- Remove prebuilt v8 support (denoland#1369)
- Enable jumbo build in release. (denoland#1362)
- Add URL implementation (denoland#1359)
- Add console.count and console.time (denoland#1358)
ry added a commit to ry/deno that referenced this pull request Dec 23, 2018
@ry
v0.2.4
af9f292 
- Upgrade V8 to 7.2.502.16 (denoland#1403)
- Remove support for extensionless import  (denoland#1396)
- make stdout unbuffered (denoland#1355)
- Implement `Body.formData` for fetch (denoland#1393)
- Improve handling of non-coercable objects in assertEqual (denoland#1385)
- Avoid fetch segfault on empty Uri (denoland#1394)
- Expose deno.inspect (denoland#1378)
- "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379)
- Add illegal header name and value guards (denoland#1375)
- Fix URLSearchParams set() and constructor() (denoland#1368)
- Remove prebuilt v8 support (denoland#1369)
- Enable jumbo build in release. (denoland#1362)
- Add URL implementation (denoland#1359)
- Add console.count and console.time (denoland#1358)
ry added a commit to ry/deno that referenced this pull request Dec 23, 2018
@ry
v0.2.4
4fe72d5 
- Upgrade V8 to 7.2.502.16 (denoland#1403)
- Remove support for extensionless import  (denoland#1396)
- make stdout unbuffered (denoland#1355)
- Implement `Body.formData` for fetch (denoland#1393)
- Improve handling of non-coercable objects in assertEqual (denoland#1385)
- Avoid fetch segfault on empty Uri (denoland#1394)
- Expose deno.inspect (denoland#1378)
- "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379)
- Add illegal header name and value guards (denoland#1375)
- Fix URLSearchParams set() and constructor() (denoland#1368)
- Remove prebuilt v8 support (denoland#1369)
- Enable jumbo build in release. (denoland#1362)
- Add URL implementation (denoland#1359)
- Add console.count and console.time (denoland#1358)
ry added a commit to ry/deno that referenced this pull request Dec 24, 2018
@ry
v0.2.4
9f72238 
- Upgrade V8 to 7.2.502.16 (denoland#1403)
- Remove support for extensionless import  (denoland#1396)
- make stdout unbuffered (denoland#1355)
- Implement `Body.formData` for fetch (denoland#1393)
- Improve handling of non-coercable objects in assertEqual (denoland#1385)
- Avoid fetch segfault on empty Uri (denoland#1394)
- Expose deno.inspect (denoland#1378)
- "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379)
- Add illegal header name and value guards (denoland#1375)
- Fix URLSearchParams set() and constructor() (denoland#1368)
- Remove prebuilt v8 support (denoland#1369)
- Enable jumbo build in release. (denoland#1362)
- Add URL implementation (denoland#1359)
- Add console.count and console.time (denoland#1358)
ry added a commit to ry/deno that referenced this pull request Dec 24, 2018
@ry
v0.2.4
c981f27 
- "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379)
- Remove support for extensionless import (denoland#1396)
- Upgrade V8 to 7.2.502.16 (denoland#1403)
- make stdout unbuffered (denoland#1355)
- Implement `Body.formData` for fetch (denoland#1393)
- Improve handling of non-coercable objects in assertEqual (denoland#1385)
- Avoid fetch segfault on empty Uri (denoland#1394)
- Expose deno.inspect (denoland#1378)
- Add illegal header name and value guards (denoland#1375)
- Fix URLSearchParams set() and constructor() (denoland#1368)
- Remove prebuilt v8 support (denoland#1369)
- Enable jumbo build in release. (denoland#1362)
- Add URL implementation (denoland#1359)
- Add console.count and console.time (denoland#1358)
- runtime arg check `URLSearchParams` (denoland#1390)
ry added a commit to ry/deno that referenced this pull request Dec 24, 2018
@ry
v0.2.4
cac3ebc 
- "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379)
- Remove support for extensionless import (denoland#1396)
- Upgrade V8 to 7.2.502.16 (denoland#1403)
- make stdout unbuffered (denoland#1355)
- Implement `Body.formData` for fetch (denoland#1393)
- Improve handling of non-coercable objects in assertEqual (denoland#1385)
- Avoid fetch segfault on empty Uri (denoland#1394)
- Expose deno.inspect (denoland#1378)
- Add illegal header name and value guards (denoland#1375)
- Fix URLSearchParams set() and constructor() (denoland#1368)
- Remove prebuilt v8 support (denoland#1369)
- Enable jumbo build in release. (denoland#1362)
- Add URL implementation (denoland#1359)
- Add console.count and console.time (denoland#1358)
- runtime arg check `URLSearchParams` (denoland#1390)
ry added a commit that referenced this pull request Dec 24, 2018
@ry
v0.2.4
c6e2fff 
- "cargo build" support (#1369 #1296 #1377 #1379)
- Remove support for extensionless import (#1396)
- Upgrade V8 to 7.2.502.16 (#1403)
- make stdout unbuffered (#1355)
- Implement `Body.formData` for fetch (#1393)
- Improve handling of non-coercable objects in assertEqual (#1385)
- Avoid fetch segfault on empty Uri (#1394)
- Expose deno.inspect (#1378)
- Add illegal header name and value guards (#1375)
- Fix URLSearchParams set() and constructor() (#1368)
- Remove prebuilt v8 support (#1369)
- Enable jumbo build in release. (#1362)
- Add URL implementation (#1359)
- Add console.count and console.time (#1358)
- runtime arg check `URLSearchParams` (#1390)
@kitsonk kitsonk deleted the assertEqual-hardening branch August 2, 2022 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

@zhmushan zhmushan zhmushan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kitsonk @ry @zhmushan