Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for extensionless import #1396

Merged
merged 6 commits into from
Dec 23, 2018
Merged

Remove support for extensionless import #1396

merged 6 commits into from
Dec 23, 2018

Conversation

ry
Copy link
Member

@ry ry commented Dec 21, 2018 •
edited

#1384

@kevinkassimo @kitsonk Please review

@ry ry force-pushed the extenionless branch 2 times, most recently from 2e2aaf4 to a5258cd Compare December 21, 2018 21:44
@ry ry requested a review from piscisaureus December 21, 2018 21:48
@ry ry changed the title WIP Remove support for extensionless import Remove support for extensionless import Dec 21, 2018
kevinkassimo
kevinkassimo reviewed Dec 21, 2018
View reviewed changes
Copy link
Contributor

@kevinkassimo kevinkassimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me. Waiting for review by @kitsonk and passing CI

src/deno_dir.rs Show resolved Hide resolved
src/deno_dir.rs Outdated Show resolved Hide resolved
kitsonk
kitsonk reviewed Dec 21, 2018
View reviewed changes
Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple thoughts.

js/deno.ts Show resolved Hide resolved
js/globals.ts Show resolved Hide resolved
src/deno_dir.rs Show resolved Hide resolved
@piscisaureus
Copy link
Member

Have fetch_local_source return None instead of NotFound on error

What motivates this?

@ry
Copy link
Member Author

ry commented Dec 23, 2018 •
edited

Have fetch_local_source return None instead of NotFound on error

What motivates this?

Because fetch_local_source returns a DenoResult<Option<CodeFetchOutput>> - which is already Ok(None) when not found in other conditions.

piscisaureus
piscisaureus reviewed Dec 23, 2018
View reviewed changes
js/globals.ts Outdated
@@ -10,7 +10,7 @@
import * as blob from "./blob";
import * as consoleTypes from "./console";
import * as domTypes from "./dom_types";
import * as file from "./file";
// import * as file from "./file";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this commented out?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

piscisaureus
piscisaureus approved these changes Dec 23, 2018
View reviewed changes
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstampy lgtm.

@ry ry merged commit 6cc998f into denoland:master Dec 23, 2018
@ry
Copy link
Member Author

ry commented Dec 23, 2018

There was also this out-of-band discussion

[11:23, 12/23/2018] Bert Belder: this patch is full of seemingly unrelated changes
[11:23, 12/23/2018] Ryan: It's because there's concept leakage that happened
[11:23, 12/23/2018] Ryan: js/*_test.ts file are run inside of deno
[11:23, 12/23/2018] Ryan: while the rest are run through rollup
[11:24, 12/23/2018] Ryan: so there's two different resolution algorithms being used
[11:24, 12/23/2018] Ryan: when we weakened the resolution scheme some js/*_test.ts were able import internal deno modules directly - without going thru the runtime

ry added a commit to ry/deno that referenced this pull request Dec 23, 2018
@ry
v0.2.4
74d0e6f 
- Upgrade V8 to 7.2.502.16 (denoland#1403)
- Remove support for extensionless import  (denoland#1396)
- make stdout unbuffered (denoland#1355)
- Implement `Body.formData` for fetch (denoland#1393)
- Improve handling of non-coercable objects in assertEqual (denoland#1385)
- Avoid fetch segfault on empty Uri (denoland#1394)
- Expose deno.inspect (denoland#1378)
- "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379)
- Add illegal header name and value guards (denoland#1375)
- Fix URLSearchParams set() and constructor() (denoland#1368)
- Remove prebuilt v8 support (denoland#1369)
- Enable jumbo build in release. (denoland#1362)
- Add URL implementation (denoland#1359)
- Add console.count and console.time (denoland#1358)
@ry ry mentioned this pull request Dec 23, 2018
Merged
ry added a commit to ry/deno that referenced this pull request Dec 23, 2018
@ry
v0.2.4
e130b4f 
- Upgrade V8 to 7.2.502.16 (denoland#1403)
- Remove support for extensionless import  (denoland#1396)
- make stdout unbuffered (denoland#1355)
- Implement `Body.formData` for fetch (denoland#1393)
- Improve handling of non-coercable objects in assertEqual (denoland#1385)
- Avoid fetch segfault on empty Uri (denoland#1394)
- Expose deno.inspect (denoland#1378)
- "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379)
- Add illegal header name and value guards (denoland#1375)
- Fix URLSearchParams set() and constructor() (denoland#1368)
- Remove prebuilt v8 support (denoland#1369)
- Enable jumbo build in release. (denoland#1362)
- Add URL implementation (denoland#1359)
- Add console.count and console.time (denoland#1358)
ry added a commit to ry/deno that referenced this pull request Dec 23, 2018
@ry
v0.2.4
af9f292 
- Upgrade V8 to 7.2.502.16 (denoland#1403)
- Remove support for extensionless import  (denoland#1396)
- make stdout unbuffered (denoland#1355)
- Implement `Body.formData` for fetch (denoland#1393)
- Improve handling of non-coercable objects in assertEqual (denoland#1385)
- Avoid fetch segfault on empty Uri (denoland#1394)
- Expose deno.inspect (denoland#1378)
- "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379)
- Add illegal header name and value guards (denoland#1375)
- Fix URLSearchParams set() and constructor() (denoland#1368)
- Remove prebuilt v8 support (denoland#1369)
- Enable jumbo build in release. (denoland#1362)
- Add URL implementation (denoland#1359)
- Add console.count and console.time (denoland#1358)
ry added a commit to ry/deno that referenced this pull request Dec 23, 2018
@ry
v0.2.4
4fe72d5 
- Upgrade V8 to 7.2.502.16 (denoland#1403)
- Remove support for extensionless import  (denoland#1396)
- make stdout unbuffered (denoland#1355)
- Implement `Body.formData` for fetch (denoland#1393)
- Improve handling of non-coercable objects in assertEqual (denoland#1385)
- Avoid fetch segfault on empty Uri (denoland#1394)
- Expose deno.inspect (denoland#1378)
- "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379)
- Add illegal header name and value guards (denoland#1375)
- Fix URLSearchParams set() and constructor() (denoland#1368)
- Remove prebuilt v8 support (denoland#1369)
- Enable jumbo build in release. (denoland#1362)
- Add URL implementation (denoland#1359)
- Add console.count and console.time (denoland#1358)
ry added a commit to ry/deno that referenced this pull request Dec 24, 2018
@ry
v0.2.4
9f72238 
- Upgrade V8 to 7.2.502.16 (denoland#1403)
- Remove support for extensionless import  (denoland#1396)
- make stdout unbuffered (denoland#1355)
- Implement `Body.formData` for fetch (denoland#1393)
- Improve handling of non-coercable objects in assertEqual (denoland#1385)
- Avoid fetch segfault on empty Uri (denoland#1394)
- Expose deno.inspect (denoland#1378)
- "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379)
- Add illegal header name and value guards (denoland#1375)
- Fix URLSearchParams set() and constructor() (denoland#1368)
- Remove prebuilt v8 support (denoland#1369)
- Enable jumbo build in release. (denoland#1362)
- Add URL implementation (denoland#1359)
- Add console.count and console.time (denoland#1358)
ry added a commit to ry/deno that referenced this pull request Dec 24, 2018
@ry
v0.2.4
c981f27 
- "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379)
- Remove support for extensionless import (denoland#1396)
- Upgrade V8 to 7.2.502.16 (denoland#1403)
- make stdout unbuffered (denoland#1355)
- Implement `Body.formData` for fetch (denoland#1393)
- Improve handling of non-coercable objects in assertEqual (denoland#1385)
- Avoid fetch segfault on empty Uri (denoland#1394)
- Expose deno.inspect (denoland#1378)
- Add illegal header name and value guards (denoland#1375)
- Fix URLSearchParams set() and constructor() (denoland#1368)
- Remove prebuilt v8 support (denoland#1369)
- Enable jumbo build in release. (denoland#1362)
- Add URL implementation (denoland#1359)
- Add console.count and console.time (denoland#1358)
- runtime arg check `URLSearchParams` (denoland#1390)
ry added a commit to ry/deno that referenced this pull request Dec 24, 2018
@ry
v0.2.4
cac3ebc 
- "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379)
- Remove support for extensionless import (denoland#1396)
- Upgrade V8 to 7.2.502.16 (denoland#1403)
- make stdout unbuffered (denoland#1355)
- Implement `Body.formData` for fetch (denoland#1393)
- Improve handling of non-coercable objects in assertEqual (denoland#1385)
- Avoid fetch segfault on empty Uri (denoland#1394)
- Expose deno.inspect (denoland#1378)
- Add illegal header name and value guards (denoland#1375)
- Fix URLSearchParams set() and constructor() (denoland#1368)
- Remove prebuilt v8 support (denoland#1369)
- Enable jumbo build in release. (denoland#1362)
- Add URL implementation (denoland#1359)
- Add console.count and console.time (denoland#1358)
- runtime arg check `URLSearchParams` (denoland#1390)
ry added a commit that referenced this pull request Dec 24, 2018
@ry
v0.2.4
c6e2fff 
- "cargo build" support (#1369 #1296 #1377 #1379)
- Remove support for extensionless import (#1396)
- Upgrade V8 to 7.2.502.16 (#1403)
- make stdout unbuffered (#1355)
- Implement `Body.formData` for fetch (#1393)
- Improve handling of non-coercable objects in assertEqual (#1385)
- Avoid fetch segfault on empty Uri (#1394)
- Expose deno.inspect (#1378)
- Add illegal header name and value guards (#1375)
- Fix URLSearchParams set() and constructor() (#1368)
- Remove prebuilt v8 support (#1369)
- Enable jumbo build in release. (#1362)
- Add URL implementation (#1359)
- Add console.count and console.time (#1358)
- runtime arg check `URLSearchParams` (#1390)
kevinkassimo referenced this pull request in egoist-labs/denopkg.com Dec 27, 2018
@egoist
docs: extensionless import might be removed in deno
6070bbb
@ry ry mentioned this pull request Jan 2, 2019
Closed
@kevinkassimo kevinkassimo mentioned this pull request Jan 7, 2019
Closed
@kevinkassimo kevinkassimo mentioned this pull request Feb 22, 2019
Closed
@kt3k kt3k mentioned this pull request Apr 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsonk kitsonk kitsonk left review comments

@kevinkassimo kevinkassimo kevinkassimo left review comments

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ry @piscisaureus @kitsonk @kevinkassimo