Update the S3 key and don't leak it any more #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
reviewed
Dec 19, 2018
.travis.yml
Outdated
| @@ -55,6 +55,10 @@ install: | |||
| rm -rf "$RUSTUP_HOME"toolchains/*/share | |||
| before_script: | |||
| - ./tools/setup.py | |||
| - |- | |||
| # Start sccache, then throw away the S3 access key. | |||
There was a problem hiding this comment.
Can you move this command to be a YAML comment. IE above the "- |-" so that in the log we can see the commands being run
ry
reviewed
Dec 19, 2018
| @@ -84,6 +88,7 @@ script: | |||
| ./tools/build.py -C target/release -j2 | |||
| DENO_BUILD_MODE=release ./tools/test.py | |||
|
|
|||
| - sccache --stop-server | |||
There was a problem hiding this comment.
Not necessary but I want to see the stats.
piscisaureus
force-pushed
the
s3key
branch
5 times, most recently
from
956ee87
to
8e3e920
Compare
This avoids accidentally leaking the key in the build log.
ry
added a commit
to ry/deno
that referenced
this pull request
Dec 23, 2018
- Upgrade V8 to 7.2.502.16 (denoland#1403) - Remove support for extensionless import (denoland#1396) - make stdout unbuffered (denoland#1355) - Implement `Body.formData` for fetch (denoland#1393) - Improve handling of non-coercable objects in assertEqual (denoland#1385) - Avoid fetch segfault on empty Uri (denoland#1394) - Expose deno.inspect (denoland#1378) - "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379) - Add illegal header name and value guards (denoland#1375) - Fix URLSearchParams set() and constructor() (denoland#1368) - Remove prebuilt v8 support (denoland#1369) - Enable jumbo build in release. (denoland#1362) - Add URL implementation (denoland#1359) - Add console.count and console.time (denoland#1358)
Merged
ry
added a commit
to ry/deno
that referenced
this pull request
Dec 23, 2018
- Upgrade V8 to 7.2.502.16 (denoland#1403) - Remove support for extensionless import (denoland#1396) - make stdout unbuffered (denoland#1355) - Implement `Body.formData` for fetch (denoland#1393) - Improve handling of non-coercable objects in assertEqual (denoland#1385) - Avoid fetch segfault on empty Uri (denoland#1394) - Expose deno.inspect (denoland#1378) - "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379) - Add illegal header name and value guards (denoland#1375) - Fix URLSearchParams set() and constructor() (denoland#1368) - Remove prebuilt v8 support (denoland#1369) - Enable jumbo build in release. (denoland#1362) - Add URL implementation (denoland#1359) - Add console.count and console.time (denoland#1358)
ry
added a commit
to ry/deno
that referenced
this pull request
Dec 23, 2018
- Upgrade V8 to 7.2.502.16 (denoland#1403) - Remove support for extensionless import (denoland#1396) - make stdout unbuffered (denoland#1355) - Implement `Body.formData` for fetch (denoland#1393) - Improve handling of non-coercable objects in assertEqual (denoland#1385) - Avoid fetch segfault on empty Uri (denoland#1394) - Expose deno.inspect (denoland#1378) - "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379) - Add illegal header name and value guards (denoland#1375) - Fix URLSearchParams set() and constructor() (denoland#1368) - Remove prebuilt v8 support (denoland#1369) - Enable jumbo build in release. (denoland#1362) - Add URL implementation (denoland#1359) - Add console.count and console.time (denoland#1358)
ry
added a commit
to ry/deno
that referenced
this pull request
Dec 23, 2018
- Upgrade V8 to 7.2.502.16 (denoland#1403) - Remove support for extensionless import (denoland#1396) - make stdout unbuffered (denoland#1355) - Implement `Body.formData` for fetch (denoland#1393) - Improve handling of non-coercable objects in assertEqual (denoland#1385) - Avoid fetch segfault on empty Uri (denoland#1394) - Expose deno.inspect (denoland#1378) - "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379) - Add illegal header name and value guards (denoland#1375) - Fix URLSearchParams set() and constructor() (denoland#1368) - Remove prebuilt v8 support (denoland#1369) - Enable jumbo build in release. (denoland#1362) - Add URL implementation (denoland#1359) - Add console.count and console.time (denoland#1358)
ry
added a commit
to ry/deno
that referenced
this pull request
Dec 24, 2018
- Upgrade V8 to 7.2.502.16 (denoland#1403) - Remove support for extensionless import (denoland#1396) - make stdout unbuffered (denoland#1355) - Implement `Body.formData` for fetch (denoland#1393) - Improve handling of non-coercable objects in assertEqual (denoland#1385) - Avoid fetch segfault on empty Uri (denoland#1394) - Expose deno.inspect (denoland#1378) - "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379) - Add illegal header name and value guards (denoland#1375) - Fix URLSearchParams set() and constructor() (denoland#1368) - Remove prebuilt v8 support (denoland#1369) - Enable jumbo build in release. (denoland#1362) - Add URL implementation (denoland#1359) - Add console.count and console.time (denoland#1358)
ry
added a commit
to ry/deno
that referenced
this pull request
Dec 24, 2018
- "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379) - Remove support for extensionless import (denoland#1396) - Upgrade V8 to 7.2.502.16 (denoland#1403) - make stdout unbuffered (denoland#1355) - Implement `Body.formData` for fetch (denoland#1393) - Improve handling of non-coercable objects in assertEqual (denoland#1385) - Avoid fetch segfault on empty Uri (denoland#1394) - Expose deno.inspect (denoland#1378) - Add illegal header name and value guards (denoland#1375) - Fix URLSearchParams set() and constructor() (denoland#1368) - Remove prebuilt v8 support (denoland#1369) - Enable jumbo build in release. (denoland#1362) - Add URL implementation (denoland#1359) - Add console.count and console.time (denoland#1358) - runtime arg check `URLSearchParams` (denoland#1390)
ry
added a commit
to ry/deno
that referenced
this pull request
Dec 24, 2018
- "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379) - Remove support for extensionless import (denoland#1396) - Upgrade V8 to 7.2.502.16 (denoland#1403) - make stdout unbuffered (denoland#1355) - Implement `Body.formData` for fetch (denoland#1393) - Improve handling of non-coercable objects in assertEqual (denoland#1385) - Avoid fetch segfault on empty Uri (denoland#1394) - Expose deno.inspect (denoland#1378) - Add illegal header name and value guards (denoland#1375) - Fix URLSearchParams set() and constructor() (denoland#1368) - Remove prebuilt v8 support (denoland#1369) - Enable jumbo build in release. (denoland#1362) - Add URL implementation (denoland#1359) - Add console.count and console.time (denoland#1358) - runtime arg check `URLSearchParams` (denoland#1390)
ry
added a commit
that referenced
this pull request
Dec 24, 2018
- "cargo build" support (#1369 #1296 #1377 #1379) - Remove support for extensionless import (#1396) - Upgrade V8 to 7.2.502.16 (#1403) - make stdout unbuffered (#1355) - Implement `Body.formData` for fetch (#1393) - Improve handling of non-coercable objects in assertEqual (#1385) - Avoid fetch segfault on empty Uri (#1394) - Expose deno.inspect (#1378) - Add illegal header name and value guards (#1375) - Fix URLSearchParams set() and constructor() (#1368) - Remove prebuilt v8 support (#1369) - Enable jumbo build in release. (#1362) - Add URL implementation (#1359) - Add console.count and console.time (#1358) - runtime arg check `URLSearchParams` (#1390)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.