feat: add page_number to metadata in DocumentSplitter #7599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…It should work as expected in issue deepset-ai#6705.
…red from the one it had on Haystack 1.x
…red from the one it had on Haystack 1.x Solve some minor bugs spotted by tests.
github-actions
bot
added
topic:tests
topic:DX
CarlosFerLo
requested review from
dfokina and
vblagoje
and removed request for
a team
|
@CarlosFerLo thank you very much for your contribution, your PR looks good - I just left some small comments to improve things a bit - let me know if it's not clear or you need help with something. |
Update docstring from suggestion Co-authored-by: David S. Batista <[email protected]>
Thanks, really appreciate it. Excited to be able to collaborate. |
Co-authored-by: David S. Batista <[email protected]>
releasenotes/notes/add-page-number-to-document-splitter-162e9dc7443575f0.yaml
Outdated
Show resolved
Hide resolved
|
|
Pull Request Test Coverage Report for Build 8876963566Details
💛 - Coveralls |
davidsbatista
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
page_numberto meta of Documents inDocumentSplitter#6705Proposed Changes:
I updated the
DocumentSplittermethods so that it adds the "page_number" field to the metadata of output documents. This field contains the page number where you can find the document on the original document. The implementation is the same as the one on the v1.25.x.How did you test it?
I added some new unit test for testing this behaviour, but testing was mainly functional as it was based on a previously functioning code.
Notes for the reviewer
This is my first contribution!!! The
.gitignorechange is to counter a VSCode extension I have that I am not able to eliminate the commit.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:. ✅