Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add page_number to metadata in DocumentSplitter #7599

Merged
merged 17 commits into from
Apr 29, 2024
Merged

feat: add page_number to metadata in DocumentSplitter #7599

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
58c4d7e
Add the .history folder to the .gitignore file.
CarlosFerLo Apr 25, 2024
9c1c153
Add the implementation for page counting used in the v1.25.x branch. …
CarlosFerLo Apr 25, 2024
6d8818f
Add tests that reflect the desired behabiour. This behabiour is inffe…
CarlosFerLo Apr 25, 2024
4be3f16
Add tests that reflect the desired behabiour. This behabiour is inffe…
CarlosFerLo Apr 25, 2024
d4f645e
Merge branch 'issue-6705' of https://github.com/carlosFerLo/haystack …
CarlosFerLo Apr 25, 2024
88106f2
Update docstrings.
CarlosFerLo Apr 25, 2024
d4c6278
Add reno.
CarlosFerLo Apr 25, 2024
3aa5313
Merge branch 'main' into issue-6705
CarlosFerLo Apr 26, 2024
d9b29cc
Update haystack/components/preprocessors/document_splitter.py
CarlosFerLo Apr 26, 2024
bd8eac2
solve suggestion to improve readability
CarlosFerLo Apr 26, 2024
c0f2fb4
Merge branch 'main' into issue-6705
CarlosFerLo Apr 26, 2024
cdb216f
fragment tests
CarlosFerLo Apr 26, 2024
72fe37d
Update haystack/components/preprocessors/document_splitter.py
CarlosFerLo Apr 26, 2024
f17acc2
Update .gitignore
davidsbatista Apr 29, 2024
7740efb
Update .gitignore
davidsbatista Apr 29, 2024
4bf78b3
Update add-page-number-to-document-splitter-162e9dc7443575f0.yaml
davidsbatista Apr 29, 2024
4903a8e
blackening
davidsbatista Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
Update add-page-number-to-document-splitter-162e9dc7443575f0.yaml
  • Loading branch information
@davidsbatista
davidsbatista committed Apr 29, 2024
commit 4bf78b3e42ed2cc444e3349059e9ed033e1ecdf9
3 changes: 0 additions & 3 deletions releasenotes/notes/add-page-number-to-document-splitter-162e9dc7443575f0.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,3 @@ highlights: >
enhancements:
- |
Now the DocumentSplitter adds the "page_number" field to the metadata of all output documents to keep track of the page of the original document it belongs to.
issues:
- |
6705