Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add page_number to metadata in DocumentSplitter #7599

Merged
merged 17 commits into from
Apr 29, 2024
Merged

feat: add page_number to metadata in DocumentSplitter #7599

merged 17 commits into from
Apr 29, 2024

Commits on Apr 25, 2024

  1. Add the .history folder to the .gitignore file.

    @CarlosFerLo
    CarlosFerLo committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    58c4d7e View commit details
    Browse the repository at this point in the history

  2. Add the implementation for page counting used in the v1.25.x branch. … 

    …It should work as expected in issue deepset-ai#6705.
    @CarlosFerLo
    CarlosFerLo committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    9c1c153 View commit details
    Browse the repository at this point in the history

  3. Add tests that reflect the desired behabiour. This behabiour is inffe… 

    …red from the one it had on Haystack 1.x
    @CarlosFerLo
    CarlosFerLo committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    6d8818f View commit details
    Browse the repository at this point in the history

  4. Add tests that reflect the desired behabiour. This behabiour is inffe… 

    …red from the one it had on Haystack 1.x

Solve some minor bugs spotted by tests.
    @CarlosFerLo
    CarlosFerLo committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    4be3f16 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'issue-6705' of https://github.com/carlosFerLo/haystack … 

    …into issue-6705
    @CarlosFerLo
    CarlosFerLo committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    d4f645e View commit details
    Browse the repository at this point in the history

  6. Update docstrings.

    @CarlosFerLo
    CarlosFerLo committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    88106f2 View commit details
    Browse the repository at this point in the history

  7. Add reno.

    @CarlosFerLo
    CarlosFerLo committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    d4c6278 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Merge branch 'main' into issue-6705

    @CarlosFerLo
    CarlosFerLo committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    3aa5313 View commit details
    Browse the repository at this point in the history

  2. Update haystack/components/preprocessors/document_splitter.py 

    Update docstring from suggestion

Co-authored-by: David S. Batista <[email protected]>
    @CarlosFerLo @davidsbatista
    CarlosFerLo and davidsbatista committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    d9b29cc View commit details
    Browse the repository at this point in the history

  3. solve suggestion to improve readability

    @CarlosFerLo
    CarlosFerLo committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    bd8eac2 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into issue-6705

    @CarlosFerLo
    CarlosFerLo committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    c0f2fb4 View commit details
    Browse the repository at this point in the history

  5. fragment tests

    @CarlosFerLo
    CarlosFerLo committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    cdb216f View commit details
    Browse the repository at this point in the history

  6. Update haystack/components/preprocessors/document_splitter.py 

    Co-authored-by: David S. Batista <[email protected]>
    @CarlosFerLo @davidsbatista
    CarlosFerLo and davidsbatista committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    72fe37d View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Update .gitignore

    @davidsbatista
    davidsbatista committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    f17acc2 View commit details
    Browse the repository at this point in the history

  2. Update .gitignore

    @davidsbatista
    davidsbatista committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    7740efb View commit details
    Browse the repository at this point in the history

  3. Update add-page-number-to-document-splitter-162e9dc7443575f0.yaml

    @davidsbatista
    davidsbatista committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    4bf78b3 View commit details
    Browse the repository at this point in the history

  4. blackening

    @davidsbatista
    davidsbatista committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    4903a8e View commit details
    Browse the repository at this point in the history