Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DocumentSplitter - split_by="page" is not documented #7828

Closed
anakin87 opened this issue Jun 7, 2024 · 2 comments
Closed

DocumentSplitter - split_by="page" is not documented #7828

anakin87 opened this issue Jun 7, 2024 · 2 comments
Assignees
@dfokina
Labels
topic:preprocessing type:documentation Improvements on the docs

Comments

@anakin87
Copy link
Member

anakin87 commented Jun 7, 2024

The DocumentSplitter can split documents by page (#6753).
The page_number is also added to meta (#7599).

This is useful but currently not documented in our docs.

@sjrl @dfokina can you take a look?
@anakin87 anakin87 changed the title DocumentSplitter - split_by="page" is not documented DocumentSplitter - split_by="page" is not documented Jun 7, 2024
@sjrl
Copy link
Contributor

sjrl commented Jun 10, 2024

The API docs for DocumentSplitter have docs explaining the split by page and adding page_number. It looks like the guide docs need to be updated. Could you take a look @dfokina?

@dfokina dfokina self-assigned this Jun 10, 2024
@dfokina
Copy link
Contributor

dfokina commented Jun 11, 2024

All added to docs 👍

@dfokina dfokina closed this as completed Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dfokina dfokina

Labels
topic:preprocessing type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sjrl @anakin87 @dfokina