feat: Add document page number of ExtractedAnswer to meta #7572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8923598800Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
sjrl
reviewed
Apr 25, 2024
| meta_to_add = {} | ||
| if answer.document and "page_number" in answer.document.meta: | ||
| ans_start = answer.document_offset.start | ||
| answer_page_number = answer.document.meta["page_number"] + answer.document.content[:ans_start].count("\f") |
There was a problem hiding this comment.
As a heads up @julian-risch there is no component in Haystack v2 that would add the page_number key to document.meta. Please see this issue #6705
github-actions
bot
added
topic:tests
type:documentation
julian-risch
requested review from
dfokina and
masci
and removed request for
a team
masci
suggested changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
ExtractedAnswermissingpage_numbermeta #7570Proposed Changes:
"answer_page_number"How did you test it?
tests are still missingRan all ExtractiveReader tests locallywe need to check whether the document's meta contains page number#7599 adds page numbers to metaNotes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.