Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AUTH-73 feat(rtp): example RTP for testing #14703

Merged
merged 31 commits into from
Apr 25, 2024
Merged

AUTH-73 feat(rtp): example RTP for testing #14703

merged 31 commits into from
Apr 25, 2024

Conversation

y3rsh
Copy link
Collaborator

@y3rsh y3rsh commented Mar 20, 2024 •
edited
Loading

Overview

https://opentrons.atlassian.net/browse/AUTH-73
https://opentrons.atlassian.net/browse/RDEVOPS-71

Examples only.
This PR will not integrate these examples into the analyses snapshot.

I lied.

@y3rsh y3rsh self-assigned this Mar 22, 2024
@DerekMaggio DerekMaggio mentioned this pull request Apr 2, 2024
Closed
@y3rsh y3rsh marked this pull request as ready for review April 19, 2024 19:32
@y3rsh y3rsh requested review from a team as code owners April 19, 2024 19:32
@DerekMaggio
Copy link
Contributor

I did notice an issue when I was changing all the file names/paths. Because we have removed API version and robot type from the file name, we are starting to have duplicate file names. In the flat list we have of all the file names, this is going to become an issue.

Instead of the file names, should we make that list the file path from the files directory?

@y3rsh
fix(test): snapshot file naming cleanup
e50194f
@y3rsh
Merge branch 'edge' into AUTH-73-golden-RTP-examples
ddb5020 
* edge: (194 commits)
  fix(app): clone run with RTPs from HistoricalProtocolRun (#14959)
  fix(api): Filter out `air_gap()` calls as higher-order commands (#14985)
  fix(app): fix infinitely re-rendering/never rendering firmware success toasts (#14981)
  feat(api): add option to ignore different tip presence states (#14980)
  feat(opentrons-ai-client) add input textbox to container (#14968)
  fix(app): add robotSerialNumber to proceedToRun event (#14976)
  fix(api): remove homing patch fix for right mount when a 96-channel is attached (#14975)
  feat(api-client,app,react-api-client): upload splash logo from desktop app (#14941)
  fix(robot-server): notify /runs when a non-current run is deleted (#14974)
  feature(api, robot-server): Allow fixit commands to recover from an error (#14908)
  feat(hardware-testing): enable multi sensor processing in liquid probe (#14883)
  fix(app): prevent "run again" banner from rendering after navigating away from the current run (#14973)
  refactor(components): refactor roundtab stories (#14956)
  refactor(protocol-designer): assign module slot in createFileWizard instead of modal (#14951)
  fix(app, api-client): fix choose protocol slideout issue (#14949)
  refactor(protocol-designer): tip position modal max values round down (#14972)
  feat(app): add tiprack selection step to quick transfer flow (#14950)
  ci(shared-data): install dependencies in workflow (#14958)
  fix(components): fix icon stories (#14969)
  feat(opentrons-ai-client): introduce react-markdown to chat display component (#14965)
  ...
@y3rsh
Copy link
Collaborator Author

y3rsh commented Apr 23, 2024

I did notice an issue when I was changing all the file names/paths. Because we have removed API version and robot type from the file name, we are starting to have duplicate file names. In the flat list we have of all the file names, this is going to become an issue.

Instead of the file names, should we make that list the file path from the files directory?

Everything back into filename but in a better organizing pattern.

DerekMaggio
DerekMaggio reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@DerekMaggio DerekMaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This newest commit looks good for renaming the files.

I think updating the README to describe how ProtocolWithOverrides is intended to be used when generating protocols would be helpful as well

app-testing/files/protocols/README.md Outdated Show resolved Hide resolved
@DerekMaggio DerekMaggio self-requested a review April 25, 2024 15:51
DerekMaggio
DerekMaggio approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@DerekMaggio DerekMaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@y3rsh y3rsh merged commit d5484f8 into edge Apr 25, 2024
7 checks passed
@y3rsh y3rsh deleted the AUTH-73-golden-RTP-examples branch April 25, 2024 16:02
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
@y3rsh @DerekMaggio @Carlos-fernandez
AUTH-73 feat(rtp): example RTP for testing (#14703)
e64dca5 
## Overview
<https://opentrons.atlassian.net/browse/AUTH-73>
<https://opentrons.atlassian.net/browse/RDEVOPS-71>

~~Examples only.~~
~~This PR will not integrate these examples into the analyses
snapshot.~~
### I lied.

---------

Co-authored-by: Derek Maggio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerekMaggio DerekMaggio DerekMaggio approved these changes

Assignees

@y3rsh y3rsh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@y3rsh @DerekMaggio