Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(opentrons-ai-client): introduce react-markdown to chat display component #14965

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Apr 19, 2024

Overview

introduce react-markdown to chat display component.

Screenshot 2024-04-19 at 3 34 50 PM

Jamey introduced react-markdown to Desktop for Release Notes modal. opentrons-ai-client uses the same package to parse markdown. For additional styling, I will discuss this with Sue.

close AUTH-359

Test Plan

  1. make teardown-js && make setup-js
  2. make -C components dev
  3. go to ChatDiplay -> OpentronsAI

Changelog

  • add react-markdown to opentrons-ai-client
  • change a prop name in ChatDisplay from text to content

Review requests

Risk assessment

low

…omponent

introduce react-markdown to chat display component

close AUTH-359
@koji koji marked this pull request as ready for review April 19, 2024 19:38
@koji koji requested a review from a team as a code owner April 19, 2024 19:38
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! i like it!

@koji koji merged commit de2b1eb into edge Apr 22, 2024
8 checks passed
@koji koji deleted the feat_add-markdown-parser branch April 22, 2024 13:44
y3rsh added a commit that referenced this pull request Apr 23, 2024
* edge: (194 commits)
  fix(app): clone run with RTPs from HistoricalProtocolRun (#14959)
  fix(api): Filter out `air_gap()` calls as higher-order commands (#14985)
  fix(app): fix infinitely re-rendering/never rendering firmware success toasts (#14981)
  feat(api): add option to ignore different tip presence states (#14980)
  feat(opentrons-ai-client) add input textbox to container (#14968)
  fix(app): add robotSerialNumber to proceedToRun event (#14976)
  fix(api): remove homing patch fix for right mount when a 96-channel is attached (#14975)
  feat(api-client,app,react-api-client): upload splash logo from desktop app (#14941)
  fix(robot-server): notify /runs when a non-current run is deleted (#14974)
  feature(api, robot-server): Allow fixit commands to recover from an error (#14908)
  feat(hardware-testing): enable multi sensor processing in liquid probe (#14883)
  fix(app): prevent "run again" banner from rendering after navigating away from the current run (#14973)
  refactor(components): refactor roundtab stories (#14956)
  refactor(protocol-designer): assign module slot in createFileWizard instead of modal (#14951)
  fix(app, api-client): fix choose protocol slideout issue (#14949)
  refactor(protocol-designer): tip position modal max values round down (#14972)
  feat(app): add tiprack selection step to quick transfer flow (#14950)
  ci(shared-data): install dependencies in workflow (#14958)
  fix(components): fix icon stories (#14969)
  feat(opentrons-ai-client): introduce react-markdown to chat display component (#14965)
  ...
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
…omponent (#14965)

* feat(opentrons-ai-client): introduce react-markdown to chat display component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants