refactor(protocol-designer): assign module slot in createFileWizard instead of modal #14951
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes AUTH-355 AUTH-22
Overview
It was a bit wonky when the module slots were being assigned previously so i refactored a lot of the logic that i made a few weeks ago. Now, the slot is assigned at the end of the create file wizard (only for MoaM) instead of during the
module and other
modal of the wizard. singular module types still get assigned slots like before - so Ot-2 behavior for instance should be the sameTest Plan
create a flex protocol and mess around with adding modules, including multiple temps, and see that they get rendered properly with nothing overlapping on the same slot
Changelog
ModulesAndOtherTile
to now just disable when there is no slot available in terms of space on the deckCreateFileWizard
Review requests
see test plan
Risk assessment
low