[ww3_multi] Fix unassigned numbers for ASCII output

[ukmo-ccbunney]

Pull Request Summary

When running ww3_multi with ASCII output (W3_ASCII switch), the unit numbers for gridded and point ASCII output are not set and default to -1.

This is causing the model to crash (at least with the GNU compiler) as the unit number is invalid.

Description

This issue only affects when running in multi grid mode.
Unit numbers are assigned to each grid/output file combination dynamically in WMINITMD.
The logic for assigning unit numbers to the new ASCII gridded/point outputs was missing.
Also, the MDS array in the same module was incorrectly sized as 13, rather than 15 elements.

Issue(s) addressed

Fixes #1116

Commit Message

Bugfix: Assign unit numbers to ASCII gridded/point output in multi-grid mode.

Check list

• Branch is up to date with the authoritative repository (NOAA-EMC) develop branch.
• Checked the checklist for a developer submitting to develop.
• If a version number update is required, checked the updating version number checklist.
• If a new feature was added, a regression test for testing the new feature is added.

Testing

• How were these changes tested? mww3_test_09 regresssion test.
• Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Yes
• Have the matrix regression tests been run (if yes, please note HPC and compiler)? Cray HPC; GNU Fortran.
• Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
• Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

[ukmo-ccbunney]

Tagging @mickaelaccensi to make sure you are happy with these changes. I think what I have done is correct. The unit number assignment in multi-grid mode is much more complicated than I realised!

I have tested this with mww3_test_09/MPI_ASCII regression test and it is all working ok now for me.
I've yet to test on full regression test matrix.

[MatthewMasarik-NOAA]

The unit number assignment in multi-grid mode is much more complicated than I realised!

This was more complicated than initially thought. Very quick work putting this all together! I'll submit the tests, and we can confirm with @mickaelaccensi in the meantime that everything checks out with him.

[MatthewMasarik-NOAA]

Code review

Pass

Testing

Pass

matrix.comp
Just the known non-b4b's.

matrixCompSummary.txt
matrixCompFull.txt
matrixDiff.txt

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (8 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (12 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (18 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (16 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)
 
**********************************************************************
************************ identical cases *****************************
**********************************************************************

[MatthewMasarik-NOAA]

@mickaelaccensi is listed as a reviewer, so I'd like to give him a chance to weigh in before moving ahead with the merge.

[mickaelaccensi]

very nice @ukmo-ccbunney ! Thanks for this fix and I confirm that I was also impressed how complex the file unit number assignation was complex for multigrid !

[MatthewMasarik-NOAA]

Perfect. Thanks @mickaelaccensi. This is ready to be merged.

[MatthewMasarik-NOAA]

Thank you for your troubleshooting, @ukmo-ccbunney.