STAB3: fix cmake build for ST4 or ST3

[MatthewMasarik-NOAA]

Pull Request Summary

Fixes a bug in the cmake build regarding the switch STAB3.

Description

Provide a detailed description of what this PR does.

• Currently selecting the STAB3 with either ST4 or ST3 as intended cannot satisfy the condition in the build that both ST4 and ST3 be selected. This makes it so that STAB3 and cannot be used with the cmake build as is. This fix resolves the issue and now STAB3 can be built with either ST3 or ST4.

What bug does it fix, or what feature does it add?

• There were 2 parts to address. In switches.json, the attribute needed to be modified. Also, a command in check_switches.cmake had two typos in the logic block that addresses switches with an "ARRAY" of dependent switches. This likely went unnoticed because we do not have any regtests using STAB3, and it is the only switch that has an array of possible dependent switches. So, the actual changes are just 1 line in each file. Some whitespace got auto-removed by my editor, so some of that is in there, too.

Is a change of answers expected from this PR?

• No. Tests confirmed using both STAB3/ST3 and STAB3/ST4 work as expected. Full matrix shows that none of the answers change, as expected.

Please also include the following information:

• Add any suggestions for a reviewer
  • @JessicaMeixner-NOAA
• Mention any labels that should be added:
  • bug
• Are answer changes expected from this PR?
  • No.

Issue(s) addressed

• fixes cmake errors on switch file with STAB3 and only one of ST4, ST3 #1082

Commit Message

STAB3: fix cmake build for ST4 or ST3

Check list

• Branch is up to date with the authoritative repository (NOAA-EMC) develop branch.
• Checked the checklist for a developer submitting to develop.
• If a version number update is required, checked the updating version number checklist.
• If a new feature was added, a regression test for testing the new feature is added.

Testing

• How were these changes tested?

  • Individual tests of STAB3 with ST4 and ST3.

• Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)

  • No, bugfix only.

• Have the matrix regression tests been run (if yes, please note HPC and compiler)?

  • Yes. hera, intel

• Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)

  • No changes.

• Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (10 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (13 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (16 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (6 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)
**********************************************************************
************************ identical cases *****************************
**********************************************************************

• matrixCompSummary.txt
• matrixCompFull.txt
• matrixDiff.txt

[JessicaMeixner-NOAA]

Regressions tests passed, however no regression test has STAB3, and attempts to add it into a regression tests and test the build have currently failed (See branch https://github.com/JessicaMeixner-NOAA/WW3/tree/bugfix/stab3 and regtest I'm trying to run here: https://github.com/JessicaMeixner-NOAA/WW3/blob/bugfix/stab3/regtests/mtest#L35 (note added switch with STAB3)) I'm waiting to confirm that I can build with STAB3 before approving this PR.

[JessicaMeixner-NOAA]

Theoretically we should add an issue that we are not properly testing STAB3 since this PR does not add a test with it. I was finally able to test that I can also build with STAB3, the other regression tests pass as expected:

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (6 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (13 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (18 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (14 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (15 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

[MatthewMasarik-NOAA]

Note that issue #1094 has been created for a STAB3 regtest.