Skip to content

Commit

Permalink
Add an LLVM patch to fix the windows build breakage from #18490 (#18538)
Browse files Browse the repository at this point in the history
create DestSharedLibDir in the LLVM Makefile
  • Loading branch information
tkelman committed Sep 16, 2016
1 parent 628d0e4 commit 3a31155
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 0 deletions.
1 change: 1 addition & 0 deletions deps/llvm.mk
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,7 @@ $(eval $(call LLVM_PATCH,llvm-D14260))
$(eval $(call LLVM_PATCH,llvm-nodllalias))
$(eval $(call LLVM_PATCH,llvm-D21271-instcombine-tbaa-3.7))
$(eval $(call LLVM_PATCH,llvm-win64-reloc-dwarf))
$(eval $(call LLVM_PATCH,llvm-3.7.1_destsharedlibdir))
else ifeq ($(LLVM_VER_SHORT),3.8)
ifeq ($(LLVM_VER),3.8.0)
$(eval $(call LLVM_PATCH,llvm-D17326_unpack_load))
Expand Down
14 changes: 14 additions & 0 deletions deps/patches/llvm-3.7.1_destsharedlibdir.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
diff --git a/Makefile.rules b/Makefile.rules
index 24cac3b..4f52dbb 100644
--- a/Makefile.rules
+++ b/Makefile.rules
@@ -1234,6 +1234,9 @@ endif
DestSharedLib := $(DestSharedLibDir)/$(BaseLibName.SO)
DestSharedAlias := $(DestSharedLibDir)/$(BaseAliasName.SO)

+$(DestSharedLibDir)::
+ $(MKDIR) $(DestSharedLibDir)
+
install-local:: $(DestSharedLib)

$(DestSharedLib): $(LibName.SO) $(DestSharedLibDir)

9 comments on commit 3a31155

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels

@Sacha0
Copy link
Member

@Sacha0 Sacha0 commented on 3a31155 Sep 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nanosoldier indicates widespread memory regressions?

@tkelman
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Most likely #18520 or #18493 or #18467 ?

@TotalVerb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkelman I don't think #18467 is the cause of most of these regressions. Could be the other two; #18493 is just lowering, so it's unlikely. #18520 affects codegen and is more likely. It might also be #18519.

@tkelman
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#18519 should be a no op on llvm < 4

@yuyichao
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't really have spare cycles to bisect this right now but this is more likely caused by lowering and type inference rather than codegen. #18520 should also only affect debug info and coverage.

@tkelman
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can make nanosoldier approximately bisect for us by triggering a bunch of builds against whatever commit the previous nightly build ran on

@TotalVerb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has the cause of this been bisected yet?

Please sign in to comment.