Work around inference bug with Vararg #18467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#18457 will likely make this obsolete. |
ac8b832
to
6bffa3c
Compare
|
While it looks like #18457 is fixing this, it looks feasible to backport this to v0.5 to work around the error there. And it looks like a nice code refactoring anyways. |
|
Sure. To backport this, I should just cherry-pick the commit and submit a PR against release-0.5? |
|
the process is listed in #17418 but depending how critical this is it should probably wait until 0.5.1 |
tkelman
referenced
this pull request
Sep 17, 2016
|
Should definitely run benchmarks before merging inference stuff. |
FTFY |
TotalVerb
added a commit
to TotalVerb/julia
that referenced
this pull request
Sep 18, 2016
This was referenced Sep 18, 2016
vtjnash
added a commit
that referenced
this pull request
Sep 25, 2016
Fix Tuple inference regression from #18467
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Never inline as constant anything inferred as
Type{Tuple{Vararg}}, as the actual type could be less specific. Works around the inference part of #18450.If this is desired, it might be a good idea to run benchmarks in case this pessimizes something.