Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage of the first statement #18520

Merged
merged 1 commit into from
Sep 16, 2016
Merged

Fix coverage of the first statement #18520

merged 1 commit into from
Sep 16, 2016

Conversation

yuyichao
Copy link
Contributor

By treating the implicit line number node as, ..... well...., a implicit line number node, instead of trying to merge it with the actual first statement.

@yuyichao yuyichao added the compiler:codegen Generation of LLVM IR and native code label Sep 15, 2016
@vtjnash vtjnash merged commit 0408085 into master Sep 16, 2016
@vtjnash vtjnash deleted the yyc/codegen/coverage branch September 16, 2016 04:15
tkelman referenced this pull request Sep 17, 2016
@vtjnash
Copy link
Sponsor Member

vtjnash commented Sep 19, 2016

@nanosoldier runbenchmarks(ALL, vs = "ad77c0e")

@tkelman
Copy link
Contributor

tkelman commented Sep 19, 2016

don't think that works on a closed pr, make it as a commit comment

@tkelman
Copy link
Contributor

tkelman commented Sep 19, 2016

also missing the @ for a commit trigger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:codegen Generation of LLVM IR and native code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants