Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build fixes #18490

Merged
merged 3 commits into from
Sep 16, 2016
Merged

build fixes #18490

merged 3 commits into from
Sep 16, 2016

Conversation

vtjnash
Copy link
Sponsor Member

@vtjnash vtjnash commented Sep 13, 2016

No description provided.

@tkelman
Copy link
Contributor

tkelman commented Sep 13, 2016

needs to be tested in a clean cygwin cross compile to ensure it doesn't bring back #16759

@kshyatt kshyatt added the building Build system, or building Julia or its dependencies label Sep 13, 2016
@vtjnash vtjnash merged commit aaefcac into master Sep 16, 2016
@vtjnash vtjnash deleted the jn/build-fixes branch September 16, 2016 03:59
@tkelman
Copy link
Contributor

tkelman commented Sep 16, 2016 •
edited
Loading

I said this needed testing for a reason. Build changes need testing on all platforms in a clean build BEFORE merging.

make[3]: *** No rule to make target '/home/Tony/julia/usr-staging/llvm-3.7.1/build_Release+Asserts/home/Tony/julia/usr/bin', needed by '/home/Tony/julia/usr-staging/llvm-3.7.1/build_Release+Asserts/home/Tony/julia/usr/bin/LLVM-3.7.dll'.  Stop.
make[2]: *** [/home/Tony/julia/deps/srccache/llvm-3.7.1/Makefile.rules:880: install] Error 1
make[1]: *** [/home/Tony/julia/deps/llvm.mk:526: /home/Tony/julia/usr-staging/llvm-3.7.1/build_Release+Asserts.tgz] Error 2
make: *** [Makefile:81: julia-deps] Error 2

edit: #18538 fixes this

tkelman added a commit that referenced this pull request Sep 16, 2016
@tkelman
Add an LLVM patch to fix the windows build breakage from #18490
15b30a0 
create DestSharedLibDir in the LLVM Makefile
tkelman added a commit that referenced this pull request Sep 16, 2016
@tkelman
Add an LLVM patch to fix the windows build breakage from #18490 (#18538)
3a31155 
create DestSharedLibDir in the LLVM Makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
building Build system, or building Julia or its dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vtjnash @tkelman @kshyatt