Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows build breakage from #18490 #18538

Merged
merged 1 commit into from
Sep 16, 2016
Merged

Fix Windows build breakage from #18490 #18538

merged 1 commit into from
Sep 16, 2016

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Sep 16, 2016

Need to patch LLVM's makefiles to create DestSharedLibDir during install-llvm if the value set at that time differs from the value set during compile-llvm.

create DestSharedLibDir in the LLVM Makefile
@tkelman
Copy link
Contributor Author

tkelman commented Sep 16, 2016

cc @vtjnash or @Keno for review, I tested this in clean builds on the 3 main 64 bit arches

error was

make[3]: *** No rule to make target '/home/Tony/julia/usr-staging/llvm-3.7.1/build_Release+Asserts/home/Tony/julia/usr/bin', needed by '/home/Tony/julia/usr-staging/llvm-3.7.1/build_Release+Asserts/home/Tony/julia/usr/bin/LLVM-3.7.dll'.  Stop.
make[2]: *** [/home/Tony/julia/deps/srccache/llvm-3.7.1/Makefile.rules:880: install] Error 1
make[1]: *** [/home/Tony/julia/deps/llvm.mk:526: /home/Tony/julia/usr-staging/llvm-3.7.1/build_Release+Asserts.tgz] Error 2
make: *** [Makefile:81: julia-deps] Error 2

@tkelman tkelman mentioned this pull request Sep 16, 2016
@Keno
Copy link
Member

Keno commented Sep 16, 2016

Looks fine to me.

@tkelman tkelman merged commit 3a31155 into master Sep 16, 2016
@tkelman tkelman deleted the tk/fixwinbuild branch September 16, 2016 21:18
@tkelman
Copy link
Contributor Author

tkelman commented Sep 16, 2016

Thanks. OSX Travis failure was an unrelated freeze, and LLVM there gets used from homebrew-julia instead of built from source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants