fixing specs

app/importers/observations_importer.rb

@@ -5,7 +5,7 @@ class ObservationsImporter < FileDataImport::BaseImporter
  PERMITTED_ATTRIBUTES = %i[
  observation_type publication_date pv is_active location_accuracy
  lat lng fmu_id location_information actions_taken
- evidence_on_report validation_status is_physical_place user_id
+ evidence_type evidence_on_report validation_status is_physical_place user_id
  observer_ids
  ].freeze
 

spec/controllers/admin/observations_controller_spec.rb

@@ -13,7 +13,7 @@
  let!(:observation) { create(:gov_observation) }
 
  before do
- create(:observation_document, observation: observation)
+ create(:observation_document, observations: [observation])
  end
 
  describe "GET index" do

spec/factories/observation_documents.rb

@@ -15,7 +15,6 @@
 FactoryBot.define do
  factory :observation_document do
  user
- observation
  sequence(:name) { |n| "ObservationDocument#{n}" }
  attachment { Rack::Test::UploadedFile.new(File.join(Rails.root, "spec", "support", "files", "image.png")) }
  end

spec/integration/v1/observation_documents_spec.rb

@@ -3,7 +3,7 @@
 module V1
  describe "Observation Documents", type: :request do
  let(:user) { create(:user) }
- let(:observation) { create(:observation) }
+ let(:observation_report) { create(:observation_report) }
 
  # TODO: add attachment
  let(:document_data) {
@@ -15,7 +15,7 @@ module V1
  create: {
  success_roles: %i[admin],
  failure_roles: %i[user],
- valid_params: -> { {name: "Document one", relationships: {user: user.id, observation: observation.id}} }
+ valid_params: -> { {name: "Document one", relationships: {user: user.id, observation_report: observation_report.id}} }
  },
  edit: {
  success_roles: %i[admin],

spec/models/observation_spec.rb

@@ -43,8 +43,9 @@
  subject(:observation) { build(:observation) }
 
  it "Removes old evidences when the evidence is on the report" do
+ subject.evidence_type = "Uploaded documents"
+ subject.observation_documents << create(:observation_document)
  subject.save!
- create(:observation_document, observation: subject)
  expect(subject.observation_documents.count).to eql(1)
  subject.evidence_type = "Evidence presented in the report"
  subject.evidence_on_report = "10"
@@ -72,7 +73,7 @@
  it "is invalid there is evidence on the report but not listed where" do
  subject.evidence_type = "Evidence presented in the report"
  expect(subject.valid?).to eq(false)
- expect(subject.errors[:evidence_on_report]).to include("You must add information on where to find the evidence on the report")
+ expect(subject.errors[:evidence_on_report]).to include("can't be blank")
  end
 
  it "is invalid without observers" do
@@ -421,15 +422,15 @@
  describe "#destroy_documents" do
  before do
  @observation = create(:observation, country: @country, operator: @operator)
- create_list(:observation_document, 3, observation: @observation)
+ @observation.observation_documents = create_list(:observation_document, 3)
  end
 
  it "destroy related observation documents" do
  expect(@observation.observation_documents.size).to eql 3
 
  @observation.destroy
 
- expect(ObservationDocument.where(observation_id: @observation.id).size).to eql 0
+ expect(ObservationDocument.joins(:observations).where(observations: [@observation]).size).to eql 0
  end
  end
  end